Merge 105140 - Web Inspector: [TextPrompt] Autocomplete adds unwanted text that's hard to remove

Source/WebCore/inspector/front-end/StylesSidebarPane.js

 /*
  * Copyright (C) 2007 Apple Inc.  All rights reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 2132 matching lines @@
     {
         // BUG 53242. This cannot go into editingEnded(), as it should always happen first for any editing outcome.
         if (this._prompt) {
             this._prompt.detach();
             delete this._prompt;
         }
     },
 
     _hasBeenModifiedIncrementally: function()
     {
-        // New properties applied via up/down have an originalPropertyText and will be deleted later
+        // New properties applied via up/down or live editing have an originalPropertyText and will be deleted later
         // on, if cancelled, when the empty string gets applied as their style text.
-        return typeof this.originalPropertyText === "string";
+        return typeof this.originalPropertyText === "string" || (!!this.property.propertyText && this._newProperty);
     },
 
     applyStyleText: function(styleText, updateInterface, majorChange, isRevert)
     {
         function userOperationFinishedCallback(parentPane, updateInterface)
         {
             if (updateInterface)
                 delete parentPane._userOperation;
         }
 
         // Leave a way to cancel editing after incremental changes.
         if (!isRevert && !updateInterface && !this._hasBeenModifiedIncrementally()) {
             // Remember the rule's original CSS text on [Page](Up|Down), so it can be restored
             // if the editing is canceled.
             this.originalPropertyText = this.property.propertyText;
         }
 
         if (!this.treeOutline)
             return;
 
         var section = this.treeOutline.section;
         var elementsPanel = WebInspector.panels.elements;
         styleText = styleText.replace(/\s/g, " ").trim(); // Replace   with whitespace.
         var styleTextLength = styleText.length;
         if (!styleTextLength && updateInterface && !isRevert && this._newProperty && !this._hasBeenModifiedIncrementally()) {
-            // The user deleted everything and never applied a new property value via Up/Down scrolling, so remove the tree element and update.
+            // The user deleted everything and never applied a new property value via Up/Down scrolling/live editing, so remove the tree element and update.
             this.parent.removeChild(this);
             section.afterUpdate();
             return;
         }
 
         var currentNode = this._parentPane.node;
         if (updateInterface)
             this._parentPane._userOperation = true;
 
         function callback(userCallback, originalPropertyText, newStyle)
@@ skipping 53 matching lines @@
         switch (event.keyIdentifier) {
         case "Up":
         case "Down":
         case "PageUp":
         case "PageDown":
             if (this._handleNameOrValueUpDown(event)) {
                 event.preventDefault();
                 return;
             }
             break;
-        case "U+0009":
-            if (this.isSuggestBoxVisible()) {
-                this._suggestBox.acceptSuggestion();
-                return !this._isEditingName;
-            }
-            return this.acceptAutoComplete();
         }
 
         WebInspector.TextPrompt.prototype.onKeyDown.call(this, event);
     },
 
+    tabKeyPressed: function()
+    {
+        this.acceptAutoComplete();
+
+        // Always tab to the next field.
+        return false;
+    },
+
     _handleNameOrValueUpDown: function(event)
     {
         // Handle numeric value increment/decrement only at this point.
         if (!this._isEditingName && this._handleUpOrDownValue(event))
             return true;
 
         return false;
     },
 
     _handleUpOrDownValue: function(event)
@@ skipping 68 matching lines @@
         var prefix = wordRange.toString().toLowerCase();
         if (!prefix && !force)
             return;
 
         var results = this._cssCompletions.startsWith(prefix);
         completionsReadyCallback(results);
     }
 }
 
 WebInspector.StylesSidebarPane.CSSPropertyPrompt.prototype.__proto__ = WebInspector.TextPrompt.prototype;