Make changes for Safari to run with webdriver on the bots.

tools/testing/perf_testing/perf_README.txt

Index: tools/testing/perf_testing/perf_README.txt
===================================================================
--- tools/testing/perf_testing/perf_README.txt	(revision 3378)
+++ tools/testing/perf_testing/perf_README.txt	(working copy)
@@ -89,19 +89,22 @@
 10)Download the Chrome Driver: http://code.google.com/p/chromium/downloads/list
    and make sure it is in your path.
 
-10)Disable pop-up blocking in Safari: 
-   Preferences -> Security -> (unselect) Block pop-up windows.
+11) a) Disable pop-up blocking in Safari: 
+       Preferences -> Security -> (unselect) Block pop-up windows.
+    b) copy the file in /Library/Preferences/com.apple.Safari.plist to $DARTDIR/tools/testing/com.apple.Safari.plist

[Emily Fortuna, 2012/01/18 01:12:37]

Yes, this is horribly hack-tastic. It's the best I've come up with so far. I'm
open to other ideas. :-/

[Siggi Cherem (dart-lang), 2012/01/18 01:35:16]

yikes!, it's ok for now, feel free to add a TODO saying:
"find a less hacky way to deal with this issue"

[Jennifer Messerly, 2012/01/18 01:35:51]

we could try saving a copy of the plist file, and/or automatically editing it.
Both have downsides though, depending on how often it changes in new versions.

[Emily Fortuna, 2012/01/18 02:20:36]

The plist file is some binary format from what I could tell. At least vim
couldn't read it.

In response to Siggi's comment here:
https://chromiumcodereview.appspot.com/9252002/diff/2001/tools/testing/run_se...
the "original" is copied from Preferences to
$Dartdir/tools/testing/com.apple.Safari.plist, so we're just re-copying the
original preferences repeatedly over. So... generally the file is going to be
the same that we're copying over. The only case when it would be different is if
Safari deleted our preference settings (setting them back to the
factory-original), in which case we don't want to save that preferences file...
right? The file we're copying from never changes. So is a backup file really
recommended?


On 2012/01/18 01:35:51, John Messerly wrote:

[Siggi Cherem (dart-lang), 2012/01/18 02:27:09]

I think it's ok, maybe we want to guard this in a flag one day (not needed right
now). My worry is that the dartdir copy is a one time step, if the user changes
the browser's preferences later, we'll override it.

[Emily Fortuna, 2012/01/18 02:31:26]

True. I was working under the [bad] assumption that I'd probably be the only one
messing with this until I figure out a better solution. I'll add another warning
in there to remind myself to fix this once we have all our buildbots running.

On 2012/01/18 02:27:09, sigmund wrote:

+       (We do this because Safari deletes our preferences (on no pop-up 

[Jennifer Messerly, 2012/01/18 01:35:51]

mismatched parens ;)

[Emily Fortuna, 2012/01/18 02:20:36]

Done.

+       blocking) if it crashes (aka times out) two times in a row.
 
-11)TODO(efortuna): Deal with appengine check in! Run 
+12)TODO(efortuna): Deal with appengine check in! Run 
    '../../../third_party/appengine-python/1.5.4/appcfg.py update appengine/' 
    while standing in dart/tools/testing/perf_tests.
 
-12)Install matplotlib http://matplotlib.sourceforge.net/
+13)Install matplotlib http://matplotlib.sourceforge.net/
 
-13)Pull down benchmarks from internal repo (Google only): 
+14)Pull down benchmarks from internal repo (Google only): 
    http://chromegw.corp.google.com/viewvc/dash/trunk/internal/browserBenchmarks/README.txt?view=markup
 
-14) Run the tests! While standing in dart/tools/testing/perf_testing, run 
+15) Run the tests! While standing in dart/tools/testing/perf_testing, run 
     $> python create_graph.py --forever --verbose --perfbot 
     to run all the tests (browser performance, language correctness in the
     browser, command line performance, and self-hosted compile time and compiled