Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 9250023: Support for mousecontrol script (Closed)

Created:
8 years, 11 months ago by achuithb
Modified:
8 years, 11 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, adlr
Visibility:
Public.

Description

Support for mousecontrol script Create a common pointer_settings::SetSensitivity call applicable to all input pointer devices. Pull common code for mouse and touchpad into common functions. Add calls for mouse status, swap left-right and sensitivity. BUG=chromium-os:22305 TEST=plug in a mouse on a chromeos device. Mouse settings should appear in chrome://settings/system. Swap and pointer speed should work as expected. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118409

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : remove debug #

Patch Set 5 : nits #

Total comments: 2

Patch Set 6 : fix uma name for right button #

Patch Set 7 : review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -56 lines) Patch
M chrome/browser/chromeos/preferences.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/system/input_device_settings.h View 1 2 3 4 5 1 chunk +7 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/system/input_device_settings.cc View 1 2 3 4 5 6 3 chunks +63 lines, -50 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
achuithb
Xiyuan - adlr's mousecontrol script has landed. It supports commands 'status', 'sensitivity' and 'swap_left_right'. This ...
8 years, 11 months ago (2012-01-19 19:28:16 UTC) #1
xiyuan
LGTM http://codereview.chromium.org/9250023/diff/6003/chrome/browser/chromeos/system/input_device_settings.cc File chrome/browser/chromeos/system/input_device_settings.cc (right): http://codereview.chromium.org/9250023/diff/6003/chrome/browser/chromeos/system/input_device_settings.cc#newcode28 chrome/browser/chromeos/system/input_device_settings.cc:28: const char* kMouseControl = "/opt/google/mouse/mousecontrol"; nit: think the ...
8 years, 11 months ago (2012-01-19 20:49:40 UTC) #2
achuithb
Thanks for the review, Xiyuan! http://codereview.chromium.org/9250023/diff/6003/chrome/browser/chromeos/system/input_device_settings.cc File chrome/browser/chromeos/system/input_device_settings.cc (right): http://codereview.chromium.org/9250023/diff/6003/chrome/browser/chromeos/system/input_device_settings.cc#newcode28 chrome/browser/chromeos/system/input_device_settings.cc:28: const char* kMouseControl = ...
8 years, 11 months ago (2012-01-19 22:19:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/9250023/4006
8 years, 11 months ago (2012-01-19 22:19:21 UTC) #4
commit-bot: I haz the power
Try job failure for 9250023-4006 (retry) on linux_rel for step "ui_tests". It's a second try, ...
8 years, 11 months ago (2012-01-19 23:36:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/9250023/4006
8 years, 11 months ago (2012-01-20 00:19:16 UTC) #6
commit-bot: I haz the power
8 years, 11 months ago (2012-01-20 03:54:47 UTC) #7
Try job failure for 9250023-4006 (retry) (retry) (retry) on mac_rel for step
"browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698