Source/WebCore/html/HTMLElement.cpp - Issue 9250020: Merge 104441 - insertAdjacentHTML doesn't play nice with DocumentFragment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/html/HTMLElement.cpp

Issue 9250020: Merge 104441 - insertAdjacentHTML doesn't play nice with DocumentFragment (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/963/

Patch Set: Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Index: Source/WebCore/html/HTMLElement.cpp

===================================================================

--- Source/WebCore/html/HTMLElement.cpp (revision 105336)

+++ Source/WebCore/html/HTMLElement.cpp (working copy)

@@ -623,7 +623,7 @@

{

if (equalIgnoringCase(where, "beforeBegin") || equalIgnoringCase(where, "afterEnd")) {

ContainerNode* parent = element->parentNode();

- if (parent && parent->isDocumentNode()) {

+ if (parent && !parent->isElementNode()) {

ec = NO_MODIFICATION_ALLOWED_ERR;

return 0;

}

« no previous file with comments | « LayoutTests/fast/dom/insertAdjacentHTML-DocumentFragment-crash-expected.txt ('k') | no next file » | no next file with comments »