Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 9250016: Aura: Add "Edit Search Engines" option to the aura omnibox context menu. (Closed)

Created:
8 years, 11 months ago by varunjain
Modified:
8 years, 11 months ago
CC:
chromium-reviews, tfarina, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Aura: Add "Edit Search Engines" option to the aura omnibox context menu. BUG=109079 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118410

Patch Set 1 #

Total comments: 6

Patch Set 2 : patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -3 lines) Patch
M chrome/browser/ui/views/omnibox/omnibox_view_views.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 1 2 chunks +17 lines, -0 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_views.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M ui/views/controls/textfield/textfield_controller.h View 1 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
varunjain
8 years, 11 months ago (2012-01-18 21:47:54 UTC) #1
oshima
lgtm with nits https://chromiumcodereview.appspot.com/9250016/diff/1/chrome/browser/ui/views/omnibox/omnibox_view_views.cc File chrome/browser/ui/views/omnibox/omnibox_view_views.cc (right): https://chromiumcodereview.appspot.com/9250016/diff/1/chrome/browser/ui/views/omnibox/omnibox_view_views.cc#newcode720 chrome/browser/ui/views/omnibox/omnibox_view_views.cc:720: DCHECK(menu_contents); you probably don't need this ...
8 years, 11 months ago (2012-01-18 22:24:24 UTC) #2
varunjain
https://chromiumcodereview.appspot.com/9250016/diff/1/chrome/browser/ui/views/omnibox/omnibox_view_views.cc File chrome/browser/ui/views/omnibox/omnibox_view_views.cc (right): https://chromiumcodereview.appspot.com/9250016/diff/1/chrome/browser/ui/views/omnibox/omnibox_view_views.cc#newcode720 chrome/browser/ui/views/omnibox/omnibox_view_views.cc:720: DCHECK(menu_contents); On 2012/01/18 22:24:24, oshima wrote: > you probably ...
8 years, 11 months ago (2012-01-18 23:31:36 UTC) #3
Ben Goodger (Google)
lgtm
8 years, 11 months ago (2012-01-19 21:48:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varunjain@chromium.org/9250016/5001
8 years, 11 months ago (2012-01-19 23:15:15 UTC) #5
commit-bot: I haz the power
Try job failure for 9250016-5001 (retry) (retry) on mac_rel for step "browser_tests". It's a second ...
8 years, 11 months ago (2012-01-20 02:06:53 UTC) #6
commit-bot: I haz the power
8 years, 11 months ago (2012-01-20 04:27:55 UTC) #7

Powered by Google App Engine
This is Rietveld 408576698