Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 9250009: Fix test.dart on Windows: change all backslashes to slashes eagerly. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: fix error in stub_generator/test_config.dart Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/stub-generator/test_config.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index b42001f0f32170fd36160b0ea5965fbced3acd94..3bb4fdf8cebb298f83ceb00ba667812776436008 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -361,7 +361,8 @@ class StandardTestSuite implements TestSuite {
}
final String component = configuration['component'];
- final String testPath = new File(filename).fullPathSync();
+ final String testPath =
+ new File(filename).fullPathSync().replaceAll('\\', '/');
for (var vmOptions in optionsFromFile['vmOptions']) {
// Create a unique temporary directory for each set of vmOptions.
@@ -536,7 +537,7 @@ class StandardTestSuite implements TestSuite {
tempDir.createSync();
}
}
- tempDirPath = new File(tempDirPath).fullPathSync();
+ tempDirPath = new File(tempDirPath).fullPathSync().replaceAll('\\', '/');
for (String subdirectory in generatedTestPath) {
tempDirPath = '$tempDirPath/$subdirectory';
@@ -735,7 +736,7 @@ class DartcCompilationTestSuite extends StandardTestSuite {
String shellPath() => TestUtils.compilerPath(configuration);
List<String> additionalOptions(String filename) {
- filename = new File(filename).fullPathSync();
+ filename = new File(filename).fullPathSync().replaceAll('\\', '/');
Directory tempDir = createOutputDirectory(filename, 'dartc-test');
return
[ '--fatal-warnings', '--fatal-type-errors',
@@ -960,9 +961,9 @@ class TestUtils {
static String dartDir() {
Directory dart;
if (new File('tools/testing/dart/test_suite.dart').existsSync()) {
- return new File('.').fullPathSync();
+ return new File('.').fullPathSync().replaceAll('\\', '/');
} else if (new File('../tools/testing/dart/test_suite.dart').existsSync()) {
- return new File('..').fullPathSync();
+ return new File('..').fullPathSync().replaceAll('\\', '/');
} else {
print('Run test.dart from the dart directory or' +
' an immediate subdirectory only.');
« no previous file with comments | « tests/stub-generator/test_config.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698