Android buildbot refactor.

Android buildbot refactor.

Add distinct entry points for each type of chromium android buildbot.
Make it super-ez for a sheriff to disable (force green) any of them.

BUG=None
TEST=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118471

[John Grabowski, 2012-01-18 20:41:59]

Applying feedback from MA about using distinct entry points for bot types when
using annotator scripts.

Addressing concern raised implicitly in email thread about making sure there is
an easy way for a sheriff to disable these bots if on the main waterfall. 
Making sure we can do the same if trybots backlogged.

Note comment about bb_force_bot_green_and_exit to do just what it says.

[Peter Mayo, 2012-01-19 02:26:03]

Interesting - Have any of the other chromium trees gone to a script&annotator? 
(The chromium OS trees use this kind of approach, but as I understand it the
Chrome ones do not) I wouldn't expect the chrome sheriffs to go looking for this
ability to "fix" a red bot.

http://codereview.chromium.org/9249030/diff/1007/build/android/buildbot_funct...
File build/android/buildbot_functions.sh (right):

http://codereview.chromium.org/9249030/diff/1007/build/android/buildbot_funct...
build/android/buildbot_functions.sh:28: echo "$1 not specified as source root"
This looks like a very confusing error message to me.
Perhaps you mean to say "$1 is not a source root directory"?

http://codereview.chromium.org/9249030/diff/1007/build/android/buildbot_funct...
build/android/buildbot_functions.sh:32: cd $SRC_ROOT
And if this doesn't work?

http://codereview.chromium.org/9249030/diff/1007/build/android/buildbot_funct...
build/android/buildbot_functions.sh:46: echo "Build cannot continue."
No Step Failure or wrapper here?  Perhaps consistent use of return non-zero or
Annotate?

http://codereview.chromium.org/9249030/diff/1007/build/android/buildbot_funct...
build/android/buildbot_functions.sh:60: rm -rf "${SRC_ROOT}"/out
Perhaps StepWarnings on failure if there is such a directory?

[M-A Ruel, 2012-01-19 02:33:58]

FTR, I'm seriously bash-illiterate, I'll leave it to Peter to review this.

[John Grabowski, 2012-01-19 17:45:13]

Feedback applied.

>> Interesting - Have any of the other chromium trees 
>> gone to a script&annotator? 

To my knowledge, no.

>> I wouldn't expect the chrome sheriffs to go looking for this
>> ability to "fix" a red bot.

I would not either.  When these are enabled (try on by default, or on main
waterfall), I'll need to send out mail.  Such a mail necessarily will include
"easy disable" instructions for sheriffs.

No matter how hard I try, my efforts will eventually cause problems.  Trying to
keep cheap mitigators available will create fewer enemies (or at least keep me
off M-A's "people to kill" list.)

http://codereview.chromium.org/9249030/diff/1007/build/android/buildbot_funct...
File build/android/buildbot_functions.sh (right):

http://codereview.chromium.org/9249030/diff/1007/build/android/buildbot_funct...
build/android/buildbot_functions.sh:28: echo "$1 not specified as source root"
On 2012/01/19 02:26:03, Peter Mayo wrote:
> This looks like a very confusing error message to me.
> Perhaps you mean to say "$1 is not a source root directory"?

Updated

http://codereview.chromium.org/9249030/diff/1007/build/android/buildbot_funct...
build/android/buildbot_functions.sh:32: cd $SRC_ROOT
On 2012/01/19 02:26:03, Peter Mayo wrote:
> And if this doesn't work?

Are you suggesting I check for read permissions?  Above I make sure it is a
directory.  In any case, all of the buildbot_*.sh scripts start with
"#!/bin/bash -ex", so we'll error exit if the cd fails.

http://codereview.chromium.org/9249030/diff/1007/build/android/buildbot_funct...
build/android/buildbot_functions.sh:46: echo "Build cannot continue."
On 2012/01/19 02:26:03, Peter Mayo wrote:
> No Step Failure or wrapper here?  Perhaps consistent use of return non-zero or
> Annotate?

@@STEP_FAILURE@@@ified

http://codereview.chromium.org/9249030/diff/1007/build/android/buildbot_funct...
build/android/buildbot_functions.sh:60: rm -rf "${SRC_ROOT}"/out
On 2012/01/19 02:26:03, Peter Mayo wrote:
> Perhaps StepWarnings on failure if there is such a directory?

Added

[Peter Mayo, 2012-01-19 20:02:13]

Seriously consider replacing this in the future with a python script.  There are
many more python friendly people in and around chromium in my experience.  It
means one less tool to keep sharp, especially where you are exercising multiple
sourced scripts, and exit on fail semantics that can surprise those who don't
often use the language.

In particular the troopers that the sheriffs would call upon in the event of bot
strangeness that they don't see how to deal with.

For the moment, let's keep this moving.

LGTM

http://codereview.chromium.org/9249030/diff/1007/build/android/buildbot_funct...
File build/android/buildbot_functions.sh (right):

http://codereview.chromium.org/9249030/diff/1007/build/android/buildbot_funct...
build/android/buildbot_functions.sh:28: echo "$1 not specified as source root"
nit: Debugging would be easier if the error message pointed to all possible
causes of the failure: e.g. the wrong path being passed, the expected directory
being missing, as well as the code not passing a value.

E.g. "a valid source"

http://codereview.chromium.org/9249030/diff/1007/build/android/buildbot_funct...
build/android/buildbot_functions.sh:32: cd $SRC_ROOT
I was thinking 
cd $SRC_ROOT || { echo Unable to cd to "$SRC_ROOT" ; echo '@@@STEP_FAILURE@@@' ;
exit 1 ; }

With some sensible line wrapping.

[John Grabowski, 2012-01-20 18:59:47]

Re: python.  Will keep an eye on this to be sure it doesn't become a beast.  For
now, it's pretty simple.

Thx for the review.

http://codereview.chromium.org/9249030/diff/1007/build/android/buildbot_funct...
File build/android/buildbot_functions.sh (right):

http://codereview.chromium.org/9249030/diff/1007/build/android/buildbot_funct...
build/android/buildbot_functions.sh:28: echo "$1 not specified as source root"
On 2012/01/19 20:02:13, Peter Mayo wrote:
> nit: Debugging would be easier if the error message pointed to all possible
> causes of the failure: e.g. the wrong path being passed, the expected
directory
> being missing, as well as the code not passing a value.
> 
> E.g. "a valid source"

clarified

http://codereview.chromium.org/9249030/diff/1007/build/android/buildbot_funct...
build/android/buildbot_functions.sh:32: cd $SRC_ROOT
On 2012/01/19 20:02:13, Peter Mayo wrote:
> I was thinking 
> cd $SRC_ROOT || { echo Unable to cd to "$SRC_ROOT" ; echo '@@@STEP_FAILURE@@@'
;
> exit 1 ; }
> 
> With some sensible line wrapping.

Given all buildbot scripts do a "set -ex", I think we get this implicitly.  E.g.
the script stops, we see the command, and we see an error message.