Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Side by Side Diff: runtime/vm/code_generator_x64.cc

Issue 9246001: Improve error message for some unresolved identifiers (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/code_generator_ia32.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64.
6 #if defined(TARGET_ARCH_X64) 6 #if defined(TARGET_ARCH_X64)
7 7
8 #include "vm/code_generator.h" 8 #include "vm/code_generator.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 890 matching lines...) Expand 10 before | Expand all | Expand 10 after
901 } 901 }
902 if (IsResultNeeded(node)) { 902 if (IsResultNeeded(node)) {
903 __ pushq(RAX); 903 __ pushq(RAX);
904 } 904 }
905 } 905 }
906 906
907 907
908 void CodeGenerator::VisitPrimaryNode(PrimaryNode* node) { 908 void CodeGenerator::VisitPrimaryNode(PrimaryNode* node) {
909 // PrimaryNodes are temporary during parsing. 909 // PrimaryNodes are temporary during parsing.
910 ErrorMsg(node->token_index(), 910 ErrorMsg(node->token_index(),
911 "Unexpected primary node: %s", node->primary().ToCString()); 911 "Unresolved identifier '%s'", node->primary().ToCString());
912 } 912 }
913 913
914 914
915 void CodeGenerator::VisitCloneContextNode(CloneContextNode *node) { 915 void CodeGenerator::VisitCloneContextNode(CloneContextNode *node) {
916 const Context& result = Context::ZoneHandle(); 916 const Context& result = Context::ZoneHandle();
917 __ PushObject(result); 917 __ PushObject(result);
918 __ pushq(CTX); 918 __ pushq(CTX);
919 GenerateCallRuntime(node->id(), 919 GenerateCallRuntime(node->id(),
920 node->token_index(), kCloneContextRuntimeEntry); 920 node->token_index(), kCloneContextRuntimeEntry);
921 __ popq(RAX); 921 __ popq(RAX);
(...skipping 1876 matching lines...) Expand 10 before | Expand all | Expand 10 after
2798 const Error& error = Error::Handle( 2798 const Error& error = Error::Handle(
2799 Parser::FormatError(script, token_index, "Error", format, args)); 2799 Parser::FormatError(script, token_index, "Error", format, args));
2800 va_end(args); 2800 va_end(args);
2801 Isolate::Current()->long_jump_base()->Jump(1, error); 2801 Isolate::Current()->long_jump_base()->Jump(1, error);
2802 UNREACHABLE(); 2802 UNREACHABLE();
2803 } 2803 }
2804 2804
2805 } // namespace dart 2805 } // namespace dart
2806 2806
2807 #endif // defined TARGET_ARCH_X64 2807 #endif // defined TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « runtime/vm/code_generator_ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698