Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: tools/testing/dart/test_suite.dart

Issue 9244004: Tiny style and comment fixes to test_suite.dart. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #library("test_suite"); 5 #library("test_suite");
6 6
7 #import("status_file_parser.dart"); 7 #import("status_file_parser.dart");
8 #import("test_runner.dart"); 8 #import("test_runner.dart");
9 #import("multitest.dart"); 9 #import("multitest.dart");
10 10
(...skipping 472 matching lines...) Expand 10 before | Expand all | Expand 10 after
483 executable, 483 executable,
484 args, 484 args,
485 configuration, 485 configuration,
486 completeHandler, 486 completeHandler,
487 expectations, 487 expectations,
488 optionsFromFile['isNegative']); 488 optionsFromFile['isNegative']);
489 doTest(testCase); 489 doTest(testCase);
490 } 490 }
491 } 491 }
492 492
493 /*** 493 /**
494 * Create a directory for the generated test. Drop the path to the 494 * Create a directory for the generated test. Drop the path to the
495 * dart checkout and the final ".dart" from the test path, and replace 495 * dart checkout and the final ".dart" from the test path, and replace
496 * all path separators with underscores. 496 * all path separators with underscores.
497 * All variables are block local, except tempDir.
498 */ 497 */
499 Directory createTemporaryDirectory(String testPath, 498 Directory createTemporaryDirectory(String testPath,
500 String dartDir, 499 String dartDir,
501 String optionsName) 500 String optionsName) {
502 {
503 String testUniqueName = 501 String testUniqueName =
504 testPath.substring(dartDir.length + 1, testPath.length - 5); 502 testPath.substring(dartDir.length + 1, testPath.length - 5);
505 testUniqueName = testUniqueName.replaceAll('/', '_'); 503 testUniqueName = testUniqueName.replaceAll('/', '_');
506 testUniqueName += '-$optionsName'; 504 testUniqueName += '-$optionsName';
507 // Create '[build dir]/generated_tests/$component/$testUniqueName', 505 // Create '[build dir]/generated_tests/$component/$testUniqueName',
508 // including any intermediate directories that don't exist. 506 // including any intermediate directories that don't exist.
509 var generatedTestPath = ['generated_tests', 507 var generatedTestPath = ['generated_tests',
510 configuration['component'], 508 configuration['component'],
511 testUniqueName]; 509 testUniqueName];
512 510
(...skipping 505 matching lines...) Expand 10 before | Expand all | Expand 10 after
1018 * $noCrash tests are expected to be flaky but not crash 1016 * $noCrash tests are expected to be flaky but not crash
1019 * $pass tests are expected to pass 1017 * $pass tests are expected to pass
1020 * $failOk tests are expected to fail that we won't fix 1018 * $failOk tests are expected to fail that we won't fix
1021 * $fail tests are expected to fail that we should fix 1019 * $fail tests are expected to fail that we should fix
1022 * $crash tests are expected to crash that we should fix 1020 * $crash tests are expected to crash that we should fix
1023 * $timeout tests are allowed to timeout 1021 * $timeout tests are allowed to timeout
1024 """; 1022 """;
1025 print(report); 1023 print(report);
1026 } 1024 }
1027 } 1025 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698