Issue 9243021: Remove BeginSessionDeprecated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9243021: Remove BeginSessionDeprecated. (Closed)

Created:
8 years, 11 months ago by Sergey Ulanov

Modified:
8 years, 10 months ago

Reviewers:
Wez

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove BeginSessionDeprecated. Once M17 is released no clients will need BeginSession message from the host, so it's safe to remove it. BUG=104670 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121055 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122899

Patch Set 1 : - #

Patch Set 2 : - #

Patch Set 3 : - #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -27 lines)			Patch
M	remoting/proto/control.proto	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	remoting/proto/internal.proto	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	remoting/protocol/client_control_dispatcher.cc	View	1 chunk	+1 line, -8 lines	0 comments	Download
	remoting/protocol/host_control_dispatcher.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Wez

LGTM, but the CL description should indicate why it's OK to remove this now. Are ...

8 years, 10 months ago (2012-01-31 20:49:53 UTC) #2

Sergey Ulanov

On 2012/01/31 20:49:53, Wez wrote: > LGTM, but the CL description should indicate why it's ...

8 years, 10 months ago (2012-02-08 02:29:13 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/9243021/10001

8 years, 10 months ago (2012-02-08 02:30:42 UTC) #4

commit-bot: I haz the power

8 years, 10 months ago (2012-02-08 02:30:43 UTC) #5

Can't process patch for file remoting/protocol/host_control_dispatcher.cc.
File's status is None, patchset upload is incomplete.

Expand Messages | Collapse Messages