Give isolates names to be used during debugging.

runtime/vm/isolate.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/isolate.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/bigint_store.h"
 #include "vm/code_index_table.h"
@@ skipping 10 matching lines @@
 #include "vm/random.h"
 #include "vm/stack_frame.h"
 #include "vm/stub_code.h"
 #include "vm/thread.h"
 #include "vm/timer.h"
 #include "vm/visitor.h"
 
 namespace dart {
 
 DEFINE_FLAG(bool, report_invocation_count, false,
-    "Count function invocations and report.");
+            "Count function invocations and report.");
+DEFINE_FLAG(bool, trace_isolates, false,
+            "Trace isolate creation and shut down.");
 DECLARE_FLAG(bool, generate_gdb_symbols);
 
 
 Isolate::Isolate()
     : store_buffer_(),
       message_queue_(NULL),
       post_message_callback_(NULL),
       close_port_callback_(NULL),
+      name_(NULL),
       num_ports_(0),
       live_ports_(0),
       main_port_(0),
       heap_(NULL),
       object_store_(NULL),
       top_resource_(NULL),
       top_context_(Context::null()),
       current_zone_(NULL),
 #if defined(DEBUG)
       no_gc_scope_depth_(0),
@@ skipping 12 matching lines @@
       long_jump_base_(NULL),
       timer_list_(),
       ast_node_id_(AstNode::kNoId),
       mutex_(new Mutex()),
       stack_limit_(0),
       saved_stack_limit_(0) {
 }
 
 
 Isolate::~Isolate() {
+  delete [] name_;
   delete message_queue_;
   delete heap_;
   delete object_store_;
   // Do not delete stack resources: top_resource_ and current_zone_.
   delete bigint_store_;
   delete api_state_;
   delete stub_code_;
   delete code_index_table_;
   delete mutex_;
   mutex_ = NULL;  // Fail fast if interrupts are scheduled on a dead isolate.
@@ skipping 18 matching lines @@
   Isolate* isolate = reinterpret_cast<Isolate*>(dart_isolate);
   ASSERT(isolate != NULL);
   if (port == kCloseAllPorts) {
     isolate->message_queue()->FlushAll();
   } else {
     isolate->message_queue()->Flush(port);
   }
 }
 
 
-Isolate* Isolate::Init() {
+Isolate* Isolate::Init(const char* name_prefix) {
   Isolate* result = new Isolate();
   ASSERT(result != NULL);
 
   // TODO(5411455): For now just set the recently created isolate as
   // the current isolate.
   SetCurrent(result);
 
   // Set up the isolate message queue.
   MessageQueue* queue = new MessageQueue();
   ASSERT(queue != NULL);
   result->set_message_queue(queue);
   result->set_post_message_callback(&StandardPostMessageCallback);
   result->set_close_port_callback(&StandardClosePortCallback);
 
   // Setup the Dart API state.
   ApiState* state = new ApiState();
   ASSERT(state != NULL);
   result->set_api_state(state);
 
   // Initialize stack top and limit in case we are running the isolate in the
   // main thread.
   // TODO(5411455): Need to figure out how to set the stack limit for the
   // main thread.
   result->SetStackLimitFromCurrentTOS(reinterpret_cast<uword>(&result));
   result->set_main_port(PortMap::CreatePort());
+  result->BuildName(name_prefix);
 
   result->debugger_ = new Debugger();
   result->debugger_->Initialize(result);
+  if (FLAG_trace_isolates) {
+    if (strcmp(name_prefix, "vm-isolate") != 0) {
+      OS::Print("[+] Starting isolate:\n"
+                "\tisolate:    %s\n", result->name());
+    }
+  }
+  return result;
+}
 
-  return result;
+
+void Isolate::BuildName(const char* name_prefix) {
+  ASSERT(name_ == NULL);
+  if (name_prefix == NULL) {
+    name_prefix = "isolate";
+  }
+  const char* kFormat = "%s-%lld";
+  intptr_t len = OS::SNPrint(NULL, 0, kFormat, name_prefix, main_port()) + 1;
+  name_ = new char[len];
+  OS::SNPrint(name_, len, kFormat, name_prefix, main_port());
 }
 
 
 // TODO(5411455): Use flag to override default value and Validate the
 // stack size by querying OS.
 uword Isolate::GetSpecifiedStackSize() {
   uword stack_size = Isolate::kDefaultStackSize - Isolate::kStackSizeBuffer;
   return stack_size;
 }
 
@@ skipping 98 matching lines @@
 
   // Dump all accumalated timer data for the isolate.
   timer_list_.ReportTimers();
   if (FLAG_report_invocation_count) {
     PrintInvokedFunctions();
   }
   CompilerStats::Print();
   if (FLAG_generate_gdb_symbols) {
     DebugInfo::UnregisterAllSections();
   }
-
+  if (FLAG_trace_isolates) {
+    OS::Print("[-] Stopping isolate:\n"
+              "\tisolate:    %s\n", name());
+  }
   // TODO(5411455): For now just make sure there are no current isolates
   // as we are shutting down the isolate.
   SetCurrent(NULL);
 }
 
 
 Dart_IsolateCreateCallback Isolate::create_callback_ = NULL;
 Dart_IsolateInterruptCallback Isolate::interrupt_callback_ = NULL;
 
 
@@ skipping 99 matching lines @@
 }
 
 
 void Isolate::VisitWeakPersistentHandles(HandleVisitor* visitor) {
   if (api_state() != NULL) {
     api_state()->VisitWeakHandles(visitor);
   }
 }
 
 }  // namespace dart