Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: runtime/vm/dart_api_impl_test.cc

Issue 9242025: Enable remaining execution tests on x64. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/custom_isolate_test.cc ('k') | runtime/vm/debugger_api_impl_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl_test.cc
===================================================================
--- runtime/vm/dart_api_impl_test.cc (revision 3367)
+++ runtime/vm/dart_api_impl_test.cc (working copy)
@@ -13,7 +13,8 @@
namespace dart {
-#if defined(TARGET_ARCH_IA32) // only ia32 can run execution tests.
+// Only ia32 and x64 can run execution tests.
+#if defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_X64)
TEST_CASE(ErrorHandles) {
const char* kScriptChars =
@@ -114,7 +115,8 @@
}
-#if defined(TARGET_ARCH_IA32) // only ia32 can run execution tests.
+// Only ia32 and x64 can run execution tests.
+#if defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_X64)
TEST_CASE(ObjectEquals) {
bool equal = false;
@@ -137,6 +139,7 @@
#endif
+
TEST_CASE(BooleanValues) {
Dart_Handle str = Dart_NewString("test");
EXPECT(!Dart_IsBoolean(str));
@@ -198,7 +201,8 @@
}
-#if defined(TARGET_ARCH_IA32) // only ia32 can run execution tests.
+// Only ia32 and x64 can run execution tests.
+#if defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_X64)
TEST_CASE(NumberValues) {
// TODO(antonm): add various kinds of ints (smi, mint, bigint).
@@ -488,7 +492,8 @@
}
-#if defined(TARGET_ARCH_IA32) // only ia32 can run execution tests.
+// Only ia32 and x64 can run execution tests.
+#if defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_X64)
TEST_CASE(ListAccess) {
const char* kScriptChars =
@@ -607,7 +612,7 @@
EXPECT(Dart_IsError(result));
}
-#endif // TARGET_ARCH_IA32.
+#endif
// Unit test for entering a scope, creating a local handle and exiting
@@ -729,7 +734,8 @@
}
-#if defined(TARGET_ARCH_IA32) // only ia32 can run execution tests.
+// Only ia32 and x64 can run execution tests.
+#if defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_X64)
TEST_CASE(WeakPersistentHandle) {
Dart_Handle weak_new_ref = Dart_Null();
@@ -1027,7 +1033,8 @@
}
-#if defined(TARGET_ARCH_IA32) // only ia32 can run execution tests.
+// Only ia32 and x64 can run execution tests.
+#if defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_X64)
TEST_CASE(FieldAccess) {
const char* kScriptChars =
@@ -3005,6 +3012,6 @@
Isolate::SetInterruptCallback(saved);
}
-#endif // TARGET_ARCH_IA32.
+#endif // defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_X64).
} // namespace dart
« no previous file with comments | « runtime/vm/custom_isolate_test.cc ('k') | runtime/vm/debugger_api_impl_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698