Factor out chunk encoding logic into HttpStreamParser::EncodeChunk().

net/http/http_stream_parser.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_HTTP_STREAM_PARSER_H_
 #define NET_HTTP_HTTP_STREAM_PARSER_H_
 #pragma once
 
 #include <string>
 
 #include "base/basictypes.h"
+#include "base/string_piece.h"
 #include "net/base/completion_callback.h"
 #include "net/base/net_log.h"
 #include "net/base/upload_data_stream.h"
 #include "net/http/http_chunked_decoder.h"
 
 namespace net {
 
 class ClientSocketHandle;
 class DrainableIOBuffer;
 class GrowableIOBuffer;
@@ skipping 48 matching lines @@
 
   bool IsConnectionReusable() const;
 
   void GetSSLInfo(SSLInfo* ssl_info);
 
   void GetSSLCertRequestInfo(SSLCertRequestInfo* cert_request_info);
 
   // ChunkCallback methods.
   virtual void OnChunkAvailable() OVERRIDE;
 
+  // Encodes the given |payload| in the chunked format to |output|.
+  // Returns the number of bytes written to |output|. |output_size| should
+  // be large enough to store the encoded chunk, which is payload.size() +
+  // kChunkHeaderFooterSize. Returns -1 if |output_size| is not large

[wtc, 2012/01/18 22:49:24]

Instead of -1, you can return a network error code such as
ERR_FAILED or some other more specific error code.  (We can
add an error code for an output buffer that's not large enough.)

[satorux1, 2012/01/18 23:42:30]

Good idea. I chose to use ERR_FAILED.

[satorux1, 2012/01/18 23:44:02]

Changed it to ERR_INVALID_ARGUMENT as it sounded a bit more appropriate here.

+  // enough.
+  //
+  // The output will look like: "HEX\r\n[payload]\r\n".

[wtc, 2012/01/18 22:49:24]

Nit: should explain what HEX is.  For example,
  where HEX is a length in hexdecimal (without the "0x" prefix)

[satorux1, 2012/01/18 23:42:30]

Good idea. Done.

+  static int EncodeChunk(const base::StringPiece& payload,
+                         char* output,
+                         size_t output_size);
+
+  // The number of extra bytes required to encode a chunk.
+  static const int kChunkHeaderFooterSize;

[wtc, 2012/01/18 22:49:24]

This constant should have the type size_t.

[satorux1, 2012/01/18 23:42:30]

Done.

+
  private:
   // FOO_COMPLETE states implement the second half of potentially asynchronous
   // operations and don't necessarily mean that FOO is complete.
   enum State {
     STATE_NONE,
     STATE_SENDING_HEADERS,
     STATE_SENDING_BODY,
     STATE_REQUEST_SENT,
     STATE_READ_HEADERS,
     STATE_READ_HEADERS_COMPLETE,
@@ skipping 108 matching lines @@
   size_t chunk_length_;
   size_t chunk_length_without_encoding_;
   bool sent_last_chunk_;
 
   DISALLOW_COPY_AND_ASSIGN(HttpStreamParser);
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_STREAM_PARSER_H_