Switch chrome code to use content::WebUI interface instead of WebUI concrete class. The latter wi...

chrome/browser/printing/print_dialog_cloud_internal.h

Index: chrome/browser/printing/print_dialog_cloud_internal.h
===================================================================
--- chrome/browser/printing/print_dialog_cloud_internal.h	(revision 117926)
+++ chrome/browser/printing/print_dialog_cloud_internal.h	(working copy)
@@ -31,24 +31,23 @@
 // Small class to virtualize a few functions to aid with unit testing.
 class CloudPrintDataSenderHelper {
  public:
-  explicit CloudPrintDataSenderHelper(WebUI* web_ui) : web_ui_(web_ui) {}
+  explicit CloudPrintDataSenderHelper(content::WebUI* web_ui)
+      : web_ui_(web_ui) {}
   virtual ~CloudPrintDataSenderHelper() {}
 
-  // Virtualize the overrides of these three functions from WebUI to
-  // facilitate unit testing.
-  virtual void CallJavascriptFunction(const std::wstring& function_name);
-  virtual void CallJavascriptFunction(const std::wstring& function_name,
-                                      const base::Value& arg);
-  virtual void CallJavascriptFunction(const std::wstring& function_name,
-                                      const base::Value& arg1,
-                                      const base::Value& arg2);
-  virtual void CallJavascriptFunction(const std::wstring& function_name,
-                                      const base::Value& arg1,
-                                      const base::Value& arg2,
-                                      const base::Value& arg3);
+  void CallJavascriptFunction(const std::wstring& function_name);

[Elliot Glaysher, 2012/01/18 01:34:08]

Is it really ok to devirtualize these methods? MockCloudPrintDataSenderHelper
overrides them.

[jam, 2012/01/18 01:41:38]

no, that was me learning about why it's not ok to do this :) i've reverted this
in the second patchset

+  void CallJavascriptFunction(const std::wstring& function_name,
+                              const base::Value& arg);
+  void CallJavascriptFunction(const std::wstring& function_name,
+                              const base::Value& arg1,
+                              const base::Value& arg2);
+  void CallJavascriptFunction(const std::wstring& function_name,
+                              const base::Value& arg1,
+                              const base::Value& arg2,
+                              const base::Value& arg3);
 
  private:
-  WebUI* web_ui_;
+  content::WebUI* web_ui_;
 
   DISALLOW_COPY_AND_ASSIGN(CloudPrintDataSenderHelper);
 };