Switch chrome code to use content::WebUI interface instead of WebUI concrete class. The latter wi...

Switch chrome code to use content::WebUI interface instead of WebUI concrete class. The latter will be renamed to WebUIImpl in a followup change. This completes hiding WebUI from chrome code, and now we can block it through DEPS.

BUG=98716
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118038

[jam, 2012-01-18 00:52:27]

Sorry this patch touches so many files. there was no way to avoid it because
changing WebUIController to take a contetn::WebUI necessarily means updating
every single WebUIController and WebUIMessageHandler file. The good news is that
most of the changes are trivial additions of "content::" or switching the
include file.

the only non-trivial thing is that I've commented out the
sync_internals_ui_unittest.cc. i've put a lot more info in the bug. but the way
that this test is currently written is not compatible with WebUI being hidden
from chrome. that test is really only testing two lines in sync_internals_ui.cc.
the rest is testing how WebUI serializes arguments. that should be done in a
separate test in content, since we wouldn't want every single WebUI page to test
how WebUI serializes arguments.

[Elliot Glaysher, 2012-01-18 01:34:08]

Y U SEND ME HUNDRED FILE PATCH?

https://chromiumcodereview.appspot.com/9241032/diff/1/chrome/browser/printing...
File chrome/browser/printing/print_dialog_cloud_internal.h (right):

https://chromiumcodereview.appspot.com/9241032/diff/1/chrome/browser/printing...
chrome/browser/printing/print_dialog_cloud_internal.h:38: void
CallJavascriptFunction(const std::wstring& function_name);
Is it really ok to devirtualize these methods? MockCloudPrintDataSenderHelper
overrides them.

https://chromiumcodereview.appspot.com/9241032/diff/14001/content/browser/web...
File content/browser/webui/web_ui.h (right):

https://chromiumcodereview.appspot.com/9241032/diff/14001/content/browser/web...
content/browser/webui/web_ui.h:17: class CONTENT_EXPORT WebUI : public
content::WebUI,
Are you planing on renaming this to impl, eventually?

WebUI deriving from content::WebUI is confusing and probably error prone.

[jam, 2012-01-18 01:41:38]

https://chromiumcodereview.appspot.com/9241032/diff/1/chrome/browser/printing...
File chrome/browser/printing/print_dialog_cloud_internal.h (right):

https://chromiumcodereview.appspot.com/9241032/diff/1/chrome/browser/printing...
chrome/browser/printing/print_dialog_cloud_internal.h:38: void
CallJavascriptFunction(const std::wstring& function_name);
On 2012/01/18 01:34:08, Elliot Glaysher wrote:
> Is it really ok to devirtualize these methods? MockCloudPrintDataSenderHelper
> overrides them.

no, that was me learning about why it's not ok to do this :) i've reverted this
in the second patchset

https://chromiumcodereview.appspot.com/9241032/diff/14001/content/browser/web...
File content/browser/webui/web_ui.h (right):

https://chromiumcodereview.appspot.com/9241032/diff/14001/content/browser/web...
content/browser/webui/web_ui.h:17: class CONTENT_EXPORT WebUI : public
content::WebUI,
On 2012/01/18 01:34:08, Elliot Glaysher wrote:
> Are you planing on renaming this to impl, eventually?
> 
> WebUI deriving from content::WebUI is confusing and probably error prone.

yes, after this is gets committed i will rename WebUI to content::WebUIImpl. i
didn't want to do this now so the change doesn't grow more :)

[Elliot Glaysher, 2012-01-18 01:43:41]

lgtm