Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 9241021: In the BrowserMainLoop::InitializeToolkit(), (Closed)

Created:
8 years, 11 months ago by simonhong_
Modified:
8 years, 11 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org, Ben Goodger (Google)
Visibility:
Public.

Description

In the BrowserMainLoop::InitializeToolkit(), Change gfx::GtkInitFromCommandLine's parameter from parameters_.command_line to parsed_command_line_. Contributed by simon.hong81@gmail.com BUG=none TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118030

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/browser_main_loop.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
simonhong_
Please review my issue. Thank you.
8 years, 11 months ago (2012-01-17 20:35:42 UTC) #1
stevenjb
lgtm
8 years, 11 months ago (2012-01-17 21:23:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simon.hong81@gmail.com/9241021/1
8 years, 11 months ago (2012-01-17 21:24:23 UTC) #3
commit-bot: I haz the power
Presubmit check for 9241021-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 11 months ago (2012-01-17 21:24:25 UTC) #4
stevenjb
+ ben@ for owner
8 years, 11 months ago (2012-01-17 21:26:15 UTC) #5
simonhong_
Please review my issue, ben. Thank you
8 years, 11 months ago (2012-01-17 22:20:48 UTC) #6
Ben Goodger (Google)
lgtm
8 years, 11 months ago (2012-01-17 22:26:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simon.hong81@gmail.com/9241021/1
8 years, 11 months ago (2012-01-17 22:27:18 UTC) #8
simonhong_
Does this have some problem for commit? Trybot finished this job. But it doesn't commit ...
8 years, 11 months ago (2012-01-18 02:54:05 UTC) #9
commit-bot: I haz the power
8 years, 11 months ago (2012-01-18 03:37:36 UTC) #10
Change committed as 118030

Powered by Google App Engine
This is Rietveld 408576698