Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Unified Diff: ui/aura/test/event_generator.h

Issue 9241007: Fix the Windows implementation of EventGenerator::PressKey(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/aura/test/event_generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/aura/test/event_generator.h
diff --git a/ui/aura/test/event_generator.h b/ui/aura/test/event_generator.h
index 80b83b18749a59af288b3d1e7e4c2e79bba54155..61893c78ccf7e64cf45ae358c7e33ebbb6a6a821 100644
--- a/ui/aura/test/event_generator.h
+++ b/ui/aura/test/event_generator.h
@@ -94,12 +94,14 @@ class EventGenerator {
void PressMoveAndReleaseTouchToCenterOf(Window* window);
// Generates a key press event. On platforms except Windows and X11, a key
- // event without native_event() is generated.
+ // event without native_event() is generated. Note that ui::EF_ flags should
+ // be passed as |flags|, not the native ones like 'ShiftMask' in <X11/X.h>.
// TODO(yusukes): Support native_event() on all platforms.
void PressKey(ui::KeyboardCode key_code, int flags);
// Generates a key release event. On platforms except Windows and X11, a key
- // event without native_event() is generated.
+ // event without native_event() is generated. Note that ui::EF_ flags should
+ // be passed as |flags|, not the native ones like 'ShiftMask' in <X11/X.h>.
// TODO(yusukes): Support native_event() on all platforms.
void ReleaseKey(ui::KeyboardCode key_code, int flags);
« no previous file with comments | « no previous file | ui/aura/test/event_generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698