Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 9241007: Fix the Windows implementation of EventGenerator::PressKey(). (Closed)

Created:
8 years, 11 months ago by Yusuke Sato
Modified:
8 years, 11 months ago
CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Fix the Windows implementation of EventGenerator::PressKey(). On Windows, we have to explicitly overwrite Event::flags_ since the flags are not determined by a MSG object but by GetKeyState() Win32 API. This CL is necessary for https://chromiumcodereview.appspot.com/9228013/. BUG=None TEST=try Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118414

Patch Set 1 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M ui/aura/test/event_generator.h View 1 chunk +4 lines, -2 lines 0 comments Download
M ui/aura/test/event_generator.cc View 3 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Yusuke Sato
8 years, 11 months ago (2012-01-18 05:09:05 UTC) #1
Yusuke Sato
Ben, could you review this?
8 years, 11 months ago (2012-01-19 23:06:55 UTC) #2
Ben Goodger (Google)
lgtm
8 years, 11 months ago (2012-01-19 23:12:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/9241007/6002
8 years, 11 months ago (2012-01-19 23:19:20 UTC) #4
commit-bot: I haz the power
Try job failure for 9241007-6002 (retry) (retry) (retry) on mac_rel for step "browser_tests". It's a ...
8 years, 11 months ago (2012-01-20 03:08:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/9241007/6002
8 years, 11 months ago (2012-01-20 03:20:07 UTC) #6
commit-bot: I haz the power
8 years, 11 months ago (2012-01-20 05:16:14 UTC) #7
Try job failure for 9241007-6002 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698