Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: ui/base/keycodes/keyboard_code_conversion_x.cc

Issue 9241002: Do not map XK_Meta_L/R to VKEY_L/RWIN. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/keycodes/keyboard_code_conversion_x.cc
diff --git a/ui/base/keycodes/keyboard_code_conversion_x.cc b/ui/base/keycodes/keyboard_code_conversion_x.cc
index ee6fe9e18360368284a1a05bb3e0668457c77ec1..8c764b389f6afe0e77ec874fc99f524a633f4562 100644
--- a/ui/base/keycodes/keyboard_code_conversion_x.cc
+++ b/ui/base/keycodes/keyboard_code_conversion_x.cc
@@ -289,12 +289,11 @@ KeyboardCode KeyboardCodeFromXKeysym(unsigned int keysym) {
return VKEY_INSERT;
case XK_Help:
return VKEY_HELP;
- case XK_Meta_L:
case XK_Super_L:
return VKEY_LWIN;
- case XK_Meta_R:
case XK_Super_R:
return VKEY_RWIN;
+ // Do not map XK_Meta_* to Windows keys. See crbug.com/110361.
Daniel Erat 2012/01/17 17:05:12 I think that this comment is probably unnecessary
Yusuke Sato 2012/01/18 05:19:54 Sure, removed.
case XK_Menu:
return VKEY_APPS;
case XK_F1:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698