Do not map XK_Meta_L/R to VKEY_L/RWIN.

Do not map XK_Meta_L/R to VKEY_L/RWIN.

BUG=110361
BUG=110129
TEST=try


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118103

[sky, 2012-01-17 16:58:54]

I don't know enough about this to say if this is right. Dan and/or Sadrul
hopefully know.

https://chromiumcodereview.appspot.com/9241002/diff/1/ui/base/keycodes/keyboa...
File ui/base/keycodes/keyboard_code_conversion_x.cc (right):

https://chromiumcodereview.appspot.com/9241002/diff/1/ui/base/keycodes/keyboa...
ui/base/keycodes/keyboard_code_conversion_x.cc:590: return XK_Meta_L;
What about this and the next case?

[Daniel Erat, 2012-01-17 17:05:12]

Looks okay to me after Scott's comment is addressed.

https://chromiumcodereview.appspot.com/9241002/diff/1/ui/base/keycodes/keyboa...
File ui/base/keycodes/keyboard_code_conversion_x.cc (right):

https://chromiumcodereview.appspot.com/9241002/diff/1/ui/base/keycodes/keyboa...
ui/base/keycodes/keyboard_code_conversion_x.cc:296: // Do not map XK_Meta_* to
Windows keys. See crbug.com/110361.
I think that this comment is probably unnecessary -- I wouldn't expect Meta to
be mapped to the Windows key in the first place.

[Yusuke Sato, 2012-01-18 05:19:54]

Please take another look.

https://chromiumcodereview.appspot.com/9241002/diff/1/ui/base/keycodes/keyboa...
File ui/base/keycodes/keyboard_code_conversion_x.cc (right):

https://chromiumcodereview.appspot.com/9241002/diff/1/ui/base/keycodes/keyboa...
ui/base/keycodes/keyboard_code_conversion_x.cc:296: // Do not map XK_Meta_* to
Windows keys. See crbug.com/110361.
On 2012/01/17 17:05:12, Daniel Erat wrote:
> I think that this comment is probably unnecessary -- I wouldn't expect Meta to
> be mapped to the Windows key in the first place.

Sure, removed.

https://chromiumcodereview.appspot.com/9241002/diff/1/ui/base/keycodes/keyboa...
ui/base/keycodes/keyboard_code_conversion_x.cc:590: return XK_Meta_L;
On 2012/01/17 16:58:55, sky wrote:
> What about this and the next case?

Thanks! Changed to XK_Super_L/R.

[Daniel Erat, 2012-01-18 15:47:34]

lgtm

[sky, 2012-01-18 15:49:12]

LGTM

[commit-bot: I haz the power, 2012-01-18 16:03:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yusukes@chromium.org/9241002/6001

[commit-bot: I haz the power, 2012-01-18 17:22:06]

Change committed as 118103