Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: tools/perf_expectations/tests/perf_expectations_unittest.py

Issue 9240017: Update expectations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf_expectations/perf_expectations.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf_expectations/tests/perf_expectations_unittest.py
diff --git a/tools/perf_expectations/tests/perf_expectations_unittest.py b/tools/perf_expectations/tests/perf_expectations_unittest.py
index 92d4308ea794abc4f1a4625c6a5941ba46618ec6..56e7c92d6a69f2b7ca538ec217a08a6f89d45823 100755
--- a/tools/perf_expectations/tests/perf_expectations_unittest.py
+++ b/tools/perf_expectations/tests/perf_expectations_unittest.py
@@ -151,7 +151,8 @@ class PerfExpectationsUnittest(unittest.TestCase):
def testNoUpdatesNeeded(self):
p = subprocess.Popen([MAKE_EXPECTATIONS, '-s'], stdout=subprocess.PIPE)
p.wait();
- self.assertEqual(p.returncode, 0, msg='Expectations has pending updates!')
+ self.assertEqual(p.returncode, 0,
+ msg='Update expectations first! (run make_expectations.py)')
Nico 2012/01/17 20:33:27 nit: I prefer diagnostic messages without exclamat
cmp 2012/01/17 20:35:46 Done.
def testConfigFile(self):
# Test that the config file can be parsed as JSON.
« no previous file with comments | « tools/perf_expectations/perf_expectations.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698