Issue 9240017: Update expectations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9240017: Update expectations. (Closed)

Created:
8 years, 11 months ago by cmp

Modified:
8 years, 11 months ago

Reviewers:
Nico

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Update expectations. Minor regression: xp-release-dual-core/moz/total_op_b/IO_op_b: http://build.chromium.org/f/chromium/perf/xp-release-dual-core/moz/report.html?history=150&rev=117931&graph=total_op_b Also update test output to be more clear. TBR=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=117949

Patch Set 2 : change message, update copyright #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	tools/perf_expectations/perf_expectations.json	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tools/perf_expectations/tests/perf_expectations_unittest.py	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

lgtm https://chromiumcodereview.appspot.com/9240017/diff/1/tools/perf_expectations/tests/perf_expectations_unittest.py File tools/perf_expectations/tests/perf_expectations_unittest.py (right): https://chromiumcodereview.appspot.com/9240017/diff/1/tools/perf_expectations/tests/perf_expectations_unittest.py#newcode155 tools/perf_expectations/tests/perf_expectations_unittest.py:155: msg='Update expectations first! (run make_expectations.py)') nit: I prefer ...

8 years, 11 months ago (2012-01-17 20:33:26 UTC) #2

cmp

8 years, 11 months ago (2012-01-17 20:35:46 UTC) #3

https://chromiumcodereview.appspot.com/9240017/diff/1/tools/perf_expectations...
File tools/perf_expectations/tests/perf_expectations_unittest.py (right):

https://chromiumcodereview.appspot.com/9240017/diff/1/tools/perf_expectations...
tools/perf_expectations/tests/perf_expectations_unittest.py:155: msg='Update
expectations first!  (run make_expectations.py)')
On 2012/01/17 20:33:27, Nico wrote:
> nit: I prefer diagnostic messages without exclamation marks. They look
> friendlier.

Done.

Expand Messages | Collapse Messages

Issue 9240017: Update expectations. (Closed)

Description

Patch Set 1 #

Patch Set 2 : change message, update copyright #

Messages