Issue 9240002: Change the signature of SetScreenshotDelegate() to show ownership transfer more clearly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9240002: Change the signature of SetScreenshotDelegate() to show ownership transfer more clearly. (Closed)

Created:
8 years, 11 months ago by Yusuke Sato

Modified:
8 years, 11 months ago

Reviewers:
mazda, Ben Goodger (Google)

CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org, Jun Mukai

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Change the signature of SetScreenshotDelegate() to show ownership transfer more clearly. BUG=None TEST=ran aura_shell_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118244

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -6 lines)			Patch
M	ash/accelerators/accelerator_controller.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	ash/accelerators/accelerator_controller.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ash/accelerators/accelerator_controller_unittest.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/chrome_browser_main_extra_parts_aura.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/9240002/6001

8 years, 11 months ago (2012-01-19 01:19:50 UTC) #5

Change committed as 118244