Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/android/java/res/layout/preference_category.xml

Issue 923803003: Fix up a few more lint warnings in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/android/java/res/layout/password_generation_popup_suggestion.xml ('K') | « chrome/android/java/res/layout/password_generation_popup_suggestion.xml ('k') | chrome/android/java/res/layout/website_settings_permission_row.xml » ('j') | chrome/android/java/res/values/colors.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/res/layout/preference_category.xml
diff --git a/chrome/android/java/res/layout/preference_category.xml b/chrome/android/java/res/layout/preference_category.xml
index e03b2760b56aa0268e6dfeb0e037be580bf65115..6d1c6cae686a817e28e821c5b5528c3b5327ebd5 100644
--- a/chrome/android/java/res/layout/preference_category.xml
+++ b/chrome/android/java/res/layout/preference_category.xml
@@ -18,6 +18,7 @@
android:layout_height="wrap_content"
android:textAppearance="@style/PreferenceCategoryTextStyle" />
+ <!-- Users of this layout are responsible to set contentBackground. -->
newt (away) 2015/02/18 18:58:11 contentDescription
aurimas (slooooooooow) 2015/02/25 01:51:17 Done
<ImageView
android:id="@android:id/icon"
android:layout_width="wrap_content"
@@ -25,6 +26,7 @@
android:minHeight="@dimen/min_touch_target_size"
android:minWidth="@dimen/min_touch_target_size"
android:scaleType="center"
- android:background="?android:attr/selectableItemBackground" />
+ android:background="?android:attr/selectableItemBackground"
+ android:contentDescription="@null" />
</LinearLayout>
« chrome/android/java/res/layout/password_generation_popup_suggestion.xml ('K') | « chrome/android/java/res/layout/password_generation_popup_suggestion.xml ('k') | chrome/android/java/res/layout/website_settings_permission_row.xml » ('j') | chrome/android/java/res/values/colors.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698