Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Side by Side Diff: chrome/android/java/res/layout/password_generation_popup_suggestion.xml

Issue 923803003: Fix up a few more lint warnings in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2014 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.
3 3
4 Use of this source code is governed by a BSD-style license that can be 4 Use of this source code is governed by a BSD-style license that can be
5 found in the LICENSE file. 5 found in the LICENSE file.
6 --> 6 -->
7 7
8 <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android" 8 <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
9 android:layout_width="wrap_content" 9 android:layout_width="wrap_content"
10 android:layout_height="wrap_content"> 10 android:layout_height="wrap_content">
11 11
12 <!-- TODO(rouslan): Fix potential overlap issues crbug.com/458384 -->
13 <!--suppress RelativeOverlap -->
newt (away) 2015/02/18 18:58:11 This looks like a false positive to me. How could
aurimas (slooooooooow) 2015/02/25 01:51:17 Done
12 <RelativeLayout android:id="@+id/password_generation_suggestion" 14 <RelativeLayout android:id="@+id/password_generation_suggestion"
13 android:layout_width="wrap_content" 15 android:layout_width="wrap_content"
14 android:layout_height="wrap_content"> 16 android:layout_height="wrap_content">
15 17
16 <ImageView android:id="@+id/password_generation_icon" 18 <ImageView android:id="@+id/password_generation_icon"
17 android:layout_width="wrap_content" 19 android:layout_width="wrap_content"
18 android:layout_height="wrap_content" 20 android:layout_height="wrap_content"
19 android:layout_marginTop="13dp" 21 android:layout_marginTop="13dp"
20 android:layout_marginBottom="13dp" 22 android:layout_marginBottom="13dp"
21 android:layout_marginStart="@dimen/password_generation_horizontal_ma rgin" 23 android:layout_marginStart="@dimen/password_generation_horizontal_ma rgin"
(...skipping 27 matching lines...) Expand all
49 51
50 </RelativeLayout> 52 </RelativeLayout>
51 53
52 <View android:id="@+id/password_generation_divider" 54 <View android:id="@+id/password_generation_divider"
53 android:layout_below="@id/password_generation_suggestion" 55 android:layout_below="@id/password_generation_suggestion"
54 android:layout_width="wrap_content" 56 android:layout_width="wrap_content"
55 android:layout_height="@dimen/password_generation_divider_height" 57 android:layout_height="@dimen/password_generation_divider_height"
56 android:background="@color/password_generation_divider_color"/> 58 android:background="@color/password_generation_divider_color"/>
57 59
58 </RelativeLayout> 60 </RelativeLayout>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698