Add OSSTATUS_LOG API

net/base/x509_cert_types_mac.cc

-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/x509_cert_types.h"
 
 #include <CoreServices/CoreServices.h>
 #include <Security/Security.h>
 #include <Security/SecAsn1Coder.h>
 
 #include "base/logging.h"
 #include "base/i18n/icu_string_conversions.h"
+#include "base/mac/mac_logging.h"
 #include "base/utf_string_conversions.h"
 
 namespace net {
 
 namespace {
 
 // The BER encoding of 0.9.2342.19200300.100.1.25.
 // On 10.6 and later this is available as CSSMOID_DomainComponent, which is an
 // external symbol from Security.framework. However, it appears that Apple's
 // implementation improperly encoded this on 10.6+, and even still is
@@ skipping 172 matching lines @@
   DCHECK(ber_name_data);
 
   // First parse the BER |name_data| into the above structs.
   SecAsn1CoderRef coder = NULL;
   SecAsn1CoderCreate(&coder);
   DCHECK(coder);
   X509Name* name = NULL;
   OSStatus err = SecAsn1Decode(coder, ber_name_data, length, kNameTemplate,
                                &name);
   if (err) {
-    LOG(ERROR) << "SecAsn1Decode returned " << err << "; name=" << name;
+    OSSTATUS_LOG(ERROR, err) << "SecAsn1Decode name=" << name;

[wtc, 2012/01/28 00:06:26]

Nit: the message should say SecAsn1Decode failed.

How about
  OSSTATUS_LOG(ERROR, err) << "SecAsn1Decode failed; name=" << name;
?

Looking at this closely, I am not sure about the value of
printing the value of 'name' on failure.  'name' is a pointer
initialized to NULL, so if the function failed, 'name' is
probably still NULL.  So I think it is enough to just say
  OSSTATUS_LOG(ERROR, err) << "SecAsn1Decode failed";

     SecAsn1CoderRelease(coder);
     return false;
   }
 
   // Now scan the structs and add the values to my string vectors.
   // I don't store multiple common/locality/state/country names, so use
   // temporary vectors for those.
   std::vector<std::string> common_names, locality_names, state_names,
       country_names;
   std::vector<std::string>* values[] = {
@@ skipping 64 matching lines @@
       match(locality_name, against.locality_name) &&
       match(state_or_province_name, against.state_or_province_name) &&
       match(country_name, against.country_name) &&
       match(street_addresses, against.street_addresses) &&
       match(organization_names, against.organization_names) &&
       match(organization_unit_names, against.organization_unit_names) &&
       match(domain_components, against.domain_components);
 }
 
 }  // namespace net