Add OSSTATUS_LOG API

chrome/browser/mac/dock.mm

-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/mac/dock.h"
 
 #include <ApplicationServices/ApplicationServices.h>
 #import <Foundation/Foundation.h>
 #include <CoreFoundation/CoreFoundation.h>
 #include <signal.h>
 
 #include "base/logging.h"
+#include "base/mac/mac_logging.h"
 #include "base/mac/mac_util.h"
 #include "base/mac/scoped_cftyperef.h"
 #include "base/mac/scoped_nsautorelease_pool.h"
 #include "base/sys_string_conversions.h"
 #include "chrome/browser/mac/launchd.h"
 
 namespace dock {
 namespace {
 
 NSString* const kDockTileDataKey = @"tile-data";
@@ skipping 56 matching lines @@
   // subsequent call to GetNextProcess, or if the Process Manager's internal
   // order of processes changes? Tolerate the race by allowing failure. Since
   // this function is only used on Leopard to find the Dock process so that it
   // can be restarted, the worst that can happen here is that the Dock won't
   // be restarted.
   ProcessSerialNumber psn = {0, kNoProcess};
   OSStatus status;
   while ((status = GetNextProcess(&psn)) == noErr) {
     pid_t process_pid;
     if ((status = GetProcessPID(&psn, &process_pid)) != noErr) {
-      LOG(ERROR) << "GetProcessPID: " << status;
+      OSSTATUS_LOG(ERROR, status) << "GetProcessPID";
       continue;
     }
 
     base::mac::ScopedCFTypeRef<CFDictionaryRef> process_dictionary(
         ProcessInformationCopyDictionary(&psn,
             kProcessDictionaryIncludeAllInformationMask));
     if (!process_dictionary.get()) {
       LOG(ERROR) << "ProcessInformationCopyDictionary";
       continue;
     }
 
-    CFStringRef process_bundle_id_cf = static_cast<CFStringRef>(
+    CFStringRef process_bundle_id_cf = base::mac::CFCast<CFStringRef>(
         CFDictionaryGetValue(process_dictionary, kCFBundleIdentifierKey));
     if (!process_bundle_id_cf) {
       // Not all processes have a bundle ID.
       continue;
-    } else if (CFGetTypeID(process_bundle_id_cf) != CFStringGetTypeID()) {
-      LOG(ERROR) << "process_bundle_id_cf not CFStringRef";
-      continue;
     }
 
     std::string process_bundle_id =
         base::SysCFStringRefToUTF8(process_bundle_id_cf);
     if (process_bundle_id == bundle_id) {
       // Found it!
       return process_pid;
     }
   }
 
   // status will be procNotFound (-600) if the process wasn't found.
-  LOG(ERROR) << "GetNextProcess: " << status;
+  OSSTATUS_LOG(ERROR, status) << "GetNextProcess";
 
   return -1;
 }
 
 // Restart the Dock process by sending it a SIGHUP.
 void Restart() {
   pid_t pid;
 
   if (base::mac::IsOSSnowLeopardOrLater()) {
     // Doing this via launchd using the proper job label is the safest way to
@@ skipping 215 matching lines @@
   }
 
   // Rewrite the plist.
   [dock_plist setObject:persistent_apps forKey:kDockPersistentAppsKey];
   [user_defaults setPersistentDomain:dock_plist forName:kDockDomain];
 
   Restart();
 }
 
 }  // namespace dock