Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4034)

Unified Diff: chrome/browser/autofill/autofill_external_delegate_gtk.cc

Issue 9235072: Adding Mouse Support for new GTK Autofill (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Responding to comments Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/autofill_external_delegate_gtk.cc
diff --git a/chrome/browser/autofill/autofill_external_delegate_gtk.cc b/chrome/browser/autofill/autofill_external_delegate_gtk.cc
index 992dbd33abc19b8eb18e66f228752cf189dfc068..4c7bbfafde75a28245e356eea35ab7b5ac2ee985 100644
--- a/chrome/browser/autofill/autofill_external_delegate_gtk.cc
+++ b/chrome/browser/autofill/autofill_external_delegate_gtk.cc
@@ -28,6 +28,17 @@ AutofillExternalDelegateGtk::AutofillExternalDelegateGtk(
AutofillExternalDelegateGtk::~AutofillExternalDelegateGtk() {
}
+void AutofillExternalDelegateGtk::HideAutofillPopupInternal() {
+ if (!view_.get())
+ return;
+
+ view_->Hide();
+ view_.reset();
+
+ GtkWidget* toplevel = gtk_widget_get_toplevel(tab_native_view_);
+ g_signal_handler_disconnect(toplevel, event_handler_id_);
+}
+
void AutofillExternalDelegateGtk::OnQueryPlatformSpecific(
int query_id,
const webkit::forms::FormData& form,
@@ -50,22 +61,12 @@ void AutofillExternalDelegateGtk::ApplyAutofillSuggestions(
separator_index);
}
-void AutofillExternalDelegateGtk::HideAutofillPopup() {
- if (!view_.get())
- return;
-
- view_->Hide();
- view_.reset();
-
- GtkWidget* toplevel = gtk_widget_get_toplevel(tab_native_view_);
- g_signal_handler_disconnect(toplevel, event_handler_id_);
-}
-
void AutofillExternalDelegateGtk::CreateViewIfNeeded() {
if (view_.get())
return;
view_.reset(new AutofillPopupViewGtk(web_contents_,
+ this,
tab_native_view_));
GtkWidget* toplevel = gtk_widget_get_toplevel(tab_native_view_);

Powered by Google App Engine
This is Rietveld 408576698