Use ByteArray's native for Socket and File.

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/bigint_operations.h"
 #include "vm/bootstrap.h"
@@ skipping 7488 matching lines @@
 }
 
 
 intptr_t ByteArray::Length() const {
   // ByteArray is an abstract class.
   UNREACHABLE();
   return 0;
 }
 
 
+void ByteArray::Copy(uint8_t* dst,
+                     const ByteArray& src,
+                     intptr_t src_offset,
+                     intptr_t length) {
+  ASSERT(Utils::RangeCheck(src_offset, length, src.Length()));
+  {
+    NoGCScope no_gc;
+    memmove(dst, src.ByteAddr(src_offset), length);
+  }
+}
+
+
+void ByteArray::Copy(const ByteArray& dst,
+                     intptr_t dst_offset,
+                     const uint8_t* src,
+                     intptr_t length) {
+  ASSERT(Utils::RangeCheck(dst_offset, length, dst.Length()));
+  {
+    NoGCScope no_gc;
+    memmove(dst.ByteAddr(dst_offset), src, length);
+  }
+}
+
+
+void ByteArray::Copy(const ByteArray& dst,
+                     intptr_t dst_offset,
+                     const ByteArray& src,
+                     intptr_t src_offset,
+                     intptr_t length) {
+  ASSERT(Utils::RangeCheck(src_offset, length, src.Length()));
+  ASSERT(Utils::RangeCheck(dst_offset, length, dst.Length()));
+  {
+    NoGCScope no_gc;
+    memmove(dst.ByteAddr(dst_offset), src.ByteAddr(src_offset), length);
+  }
+}
+
+
+uint8_t* ByteArray::ByteAddr(intptr_t byte_offset) const {
+  // ByteArray is an abstract class.
+  UNREACHABLE();
+  return NULL;
+}
+
+
 const char* ByteArray::ToCString() const {
   // ByteArray is an abstract class.
   UNREACHABLE();
   return "ByteArray";
 }
 
 
 RawInternalByteArray* InternalByteArray::New(intptr_t len,
                                              Heap::Space space) {
   Isolate* isolate = Isolate::Current();
   const Class& internal_byte_array_class =
       Class::Handle(isolate->object_store()->internal_byte_array_class());
   InternalByteArray& result = InternalByteArray::Handle();
   {
     RawObject* raw = Object::Allocate(internal_byte_array_class,
                                       InternalByteArray::InstanceSize(len),
                                       space);
     NoGCScope no_gc;
     result ^= raw;
     result.SetLength(len);
-    memset(result.Addr<uint8_t>(0), 0, len);
+    if (len > 0) {
+      memset(result.Addr<uint8_t>(0), 0, len);
+    }
   }
   return result.raw();
 }
 
 
 RawInternalByteArray* InternalByteArray::New(const uint8_t* data,
                                              intptr_t len,
                                              Heap::Space space) {
   InternalByteArray& result =
       InternalByteArray::Handle(InternalByteArray::New(len, space));
   {
     NoGCScope no_gc;
-    memmove(result.Addr<uint8_t>(0), data, len);
+    if (len > 0) {
+      memmove(result.Addr<uint8_t>(0), data, len);
+    }
   }
   return result.raw();
 }
 
 
 const char* InternalByteArray::ToCString() const {
   return "_InternalByteArray";
 }
 
 
@@ skipping 324 matching lines @@
   const String& str = String::Handle(pattern());
   const char* format = "JSRegExp: pattern=%s flags=%s";
   intptr_t len = OS::SNPrint(NULL, 0, format, str.ToCString(), Flags());
   char* chars = reinterpret_cast<char*>(
       Isolate::Current()->current_zone()->Allocate(len + 1));
   OS::SNPrint(chars, (len + 1), format, str.ToCString(), Flags());
   return chars;
 }
 
 }  // namespace dart