Use ByteArray's native for Socket and File.

runtime/lib/byte_array.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/bootstrap_natives.h"
 
 #include "vm/exceptions.h"
 #include "vm/native_entry.h"
 #include "vm/object.h"
 
@@ skipping 12 matching lines @@
     GrowableArray<const Object*> args;
     args.Add(&length);
     Exceptions::ThrowByType(Exceptions::kIllegalArgument, args);
   }
   const InternalByteArray& new_array =
       InternalByteArray::Handle(InternalByteArray::New(length.Value()));
   arguments->SetReturn(new_array);
 }
 
 
-static void RangeCheck(const ByteArray& array, const Smi& index,
+static void RangeCheck(const ByteArray& array,
+                       intptr_t index,
                        intptr_t num_bytes) {
-  if ((index.Value() < 0) || ((index.Value() + num_bytes) > array.Length())) {
+  if (!Utils::RangeCheck(index, num_bytes, array.Length())) {
     GrowableArray<const Object*> arguments;
-    arguments.Add(&index);
+    const Smi &index_object = Smi::Handle(Smi::New(index));
+    arguments.Add(&index_object);
     Exceptions::ThrowByType(Exceptions::kIndexOutOfRange, arguments);
   }
 }
 
 
+DEFINE_NATIVE_ENTRY(ByteArray_setRange, 5) {
+  ByteArray& dst = ByteArray::CheckedHandle(arguments->At(0));
+  GET_NATIVE_ARGUMENT(Smi, dst_start, arguments->At(1));
+  GET_NATIVE_ARGUMENT(Smi, length, arguments->At(2));
+  GET_NATIVE_ARGUMENT(ByteArray, src, arguments->At(3));
+  GET_NATIVE_ARGUMENT(Smi, src_start, arguments->At(4));
+  intptr_t length_value = length.Value();
+  intptr_t src_start_value = src_start.Value();
+  intptr_t dst_start_value = dst_start.Value();
+  if (length_value < 0) {
+    GrowableArray<const Object*> args;
+    Exceptions::ThrowByType(Exceptions::kIllegalArgument, args);
+  }
+  RangeCheck(src, src_start_value, length_value);
+  RangeCheck(dst, dst_start_value, length_value);
+  ByteArray::Copy(dst, dst_start_value, src, src_start_value, length_value);
+}
+
+
 #define GETTER(ArrayT, ObjectT, ValueT)                                 \
   GET_NATIVE_ARGUMENT(ArrayT, array, arguments->At(0));                 \
   GET_NATIVE_ARGUMENT(Smi, index, arguments->At(1));                    \
-  RangeCheck(array, index, sizeof(ValueT));                             \
+  RangeCheck(array, index.Value(), sizeof(ValueT));                     \
   ValueT result = array.UnalignedAt<ValueT>(index.Value());             \
   arguments->SetReturn(ObjectT::Handle(ObjectT::New(result)));
 
 
 #define SETTER(ArrayT, ObjectT, Getter, ValueT)                         \
   GET_NATIVE_ARGUMENT(ArrayT, array, arguments->At(0));                 \
   GET_NATIVE_ARGUMENT(Smi, index, arguments->At(1));                    \
-  RangeCheck(array, index, sizeof(ValueT));                             \
+  RangeCheck(array, index.Value(), sizeof(ValueT));                     \
   GET_NATIVE_ARGUMENT(ObjectT, value, arguments->At(2));                \
   array.SetUnalignedAt<ValueT>(index.Value(), value.Getter());
 
 
 DEFINE_NATIVE_ENTRY(InternalByteArray_getInt8, 2) {
   GETTER(InternalByteArray, Smi, int8_t);
 }
 
 
 DEFINE_NATIVE_ENTRY(InternalByteArray_setInt8, 3) {
@@ skipping 184 matching lines @@
 DEFINE_NATIVE_ENTRY(ExternalByteArray_getFloat64, 2) {
   GETTER(ExternalByteArray, Double, double);
 }
 
 
 DEFINE_NATIVE_ENTRY(ExternalByteArray_setFloat64, 3) {
   SETTER(ExternalByteArray, Double, value, double);
 }
 
 }  // namespace dart