Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp - Issue 9235065: Merge 105978 - crash in WebCore::RenderSVGContainer::paint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp

Issue 9235065: Merge 105978 - crash in WebCore::RenderSVGContainer::paint (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/963/

Patch Set: Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp ('k') | Source/WebCore/rendering/svg/RenderSVGResourceSolidColor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp

===================================================================

--- Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp (revision 106008)

+++ Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp (working copy)

@@ -274,6 +274,8 @@

for (Node* node = attributes.patternContentElement()->firstChild(); node; node = node->nextSibling()) {

if (!node->isSVGElement() || !static_cast<SVGElement*>(node)->isStyled() || !node->renderer())

continue;

+ if (node->renderer()->needsLayout())

+ return nullptr;

SVGImageBufferTools::renderSubtreeToImageBuffer(tileImage.get(), node->renderer(), contentTransformation);

}