Chromium Code Reviews

Issue 9235007: Handle single element array growth + transition in generic KeyedStoreIC (Closed)

Created:
8 years, 11 months ago by danno
Modified:
8 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Handle single element array growth + transition in generic KeyedStoreIC BUG=none TEST=3d-cube faster Committed: https://code.google.com/p/v8/source/detail?r=10583

Patch Set 1 #

Patch Set 2 : Implement x64 and ARM #

Patch Set 3 : Latest version #

Patch Set 4 : Merge with tip of tree #

Patch Set 5 : fix bugs #

Patch Set 6 : Turn off smi_only_arrays #

Patch Set 7 : rebase to tot #

Total comments: 8

Patch Set 8 : final version #

Unified diffs Side-by-side diffs Stats (+315 lines, -85 lines)
M src/arm/builtins-arm.cc View 2 chunks +2 lines, -3 lines 0 comments
src/arm/ic-arm.cc View 4 chunks +55 lines, -7 lines 0 comments
M src/arm/macro-assembler-arm.h View 1 chunk +15 lines, -4 lines 0 comments
M src/arm/macro-assembler-arm.cc View 1 chunk +30 lines, -15 lines 0 comments
M src/contexts.h View 1 chunk +12 lines, -0 lines 0 comments
M src/ia32/builtins-ia32.cc View 2 chunks +2 lines, -4 lines 0 comments
M src/ia32/ic-ia32.cc View 4 chunks +53 lines, -5 lines 0 comments
M src/ia32/macro-assembler-ia32.h View 1 chunk +15 lines, -4 lines 0 comments
M src/ia32/macro-assembler-ia32.cc View 1 chunk +29 lines, -15 lines 0 comments
M src/objects-printer.cc View 2 chunks +6 lines, -2 lines 0 comments
M src/x64/builtins-x64.cc View 2 chunks +2 lines, -4 lines 0 comments
M src/x64/ic-x64.cc View 4 chunks +50 lines, -3 lines 0 comments
M src/x64/macro-assembler-x64.h View 1 chunk +15 lines, -4 lines 0 comments
M src/x64/macro-assembler-x64.cc View 1 chunk +29 lines, -15 lines 0 comments

Messages

Total messages: 3 (0 generated)
danno
PTAL. Requires http://codereview.chromium.org/9050001 to be applied first.
8 years, 11 months ago (2012-01-25 12:16:25 UTC) #1
Michael Starzinger
LGTM (with nits). I left platform specific nits in ia32, but they apply to all ...
8 years, 10 months ago (2012-02-01 08:53:26 UTC) #2
danno
8 years, 10 months ago (2012-02-06 14:13:14 UTC) #3 
Landed.

https://chromiumcodereview.appspot.com/9235007/diff/44/src/contexts.h
File src/contexts.h (right):

https://chromiumcodereview.appspot.com/9235007/diff/44/src/contexts.h#newcode380
src/contexts.h:380: return SMI_JS_ARRAY_MAP_INDEX;
On 2012/02/01 08:53:26, Michael Starzinger wrote:
> Can we prefix this with "Context::" as well for clarity.

Done.

https://chromiumcodereview.appspot.com/9235007/diff/44/src/ia32/ic-ia32.cc
File src/ia32/ic-ia32.cc (right):

https://chromiumcodereview.appspot.com/9235007/diff/44/src/ia32/ic-ia32.cc#ne...
src/ia32/ic-ia32.cc:866: // Escape to slow case when writing non-smi into
smi-only array.
On 2012/02/01 08:53:26, Michael Starzinger wrote:
> This comment is no longer accurate.

Done.

https://chromiumcodereview.appspot.com/9235007/diff/44/src/ia32/ic-ia32.cc#ne...
src/ia32/ic-ia32.cc:923: // Elements are FAST_DOUBLE_WITHOUT_MAP_CHECK, but
value is an Object that's
On 2012/02/01 08:53:26, Michael Starzinger wrote:
> This constant seems bogus.

Done.

https://chromiumcodereview.appspot.com/9235007/diff/44/src/ia32/macro-assembl...
File src/ia32/macro-assembler-ia32.h (right):

https://chromiumcodereview.appspot.com/9235007/diff/44/src/ia32/macro-assembl...
src/ia32/macro-assembler-ia32.h:235: // Load the initial map for a new Arrays
from a JSFunction.
On 2012/02/01 08:53:26, Michael Starzinger wrote:
> Drop the "a" in the comment.

Done.

Powered by Google App Engine