Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9235004: [Garbled Text][Infobar] Adding infobar to suggest turning on encoding detection. (Closed)

Created:
8 years, 11 months ago by tzik
Modified:
8 years, 10 months ago
Reviewers:
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, brettw-cc_chromium.org, jam, joi+watch-content_chromium.org, arv (Not doing code reviews), darin-cc_chromium.org, ajwong+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

[Garbled Text][Infobar] Adding infobar to suggest turning on encoding detection. This CL depends on WebKit changes: https://bugs.webkit.org/show_bug.cgi?id=75594 https://bugs.webkit.org/show_bug.cgi?id=76895 A brief Design Doc available (internal only, it may contain some statistics): https://docs.google.com/a/google.com/document/d/1gHJnIMhP1cFBj2nsrTaJr0LNxdmEhm9Ams4noMSDA6k/edit https://docs.google.com/a/google.com/document/d/1gHJnIMhP1cFBj2nsrTaJr0LNxdmEhm9Ams4noMSDA6k/edit#heading=h.kkqgay87l1dd BUG=106376 TEST='GarbledTextURLTrackerTest.*,GarbledTextServiceTest.*,GarbledTextHelperTest.*,GarbledTextBrowserTest.*'

Patch Set 1 #

Patch Set 2 : Patch #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1606 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 2 3 4 5 6 3 chunks +16 lines, -0 lines 0 comments Download
A chrome/browser/garbled_text_browsertest.cc View 1 1 chunk +128 lines, -0 lines 0 comments Download
A chrome/browser/garbled_text_helper.h View 1 2 3 4 5 1 chunk +68 lines, -0 lines 0 comments Download
A chrome/browser/garbled_text_helper.cc View 1 2 3 4 5 1 chunk +128 lines, -0 lines 0 comments Download
A chrome/browser/garbled_text_helper_unittest.cc View 1 chunk +92 lines, -0 lines 0 comments Download
A chrome/browser/garbled_text_infobar_delegate.h View 1 chunk +45 lines, -0 lines 0 comments Download
A chrome/browser/garbled_text_infobar_delegate.cc View 1 chunk +53 lines, -0 lines 0 comments Download
A chrome/browser/garbled_text_service.h View 1 chunk +102 lines, -0 lines 0 comments Download
A chrome/browser/garbled_text_service.cc View 1 1 chunk +185 lines, -0 lines 0 comments Download
A chrome/browser/garbled_text_service_unittest.cc View 1 1 chunk +137 lines, -0 lines 0 comments Download
A chrome/browser/garbled_text_test_helper.h View 1 chunk +41 lines, -0 lines 0 comments Download
A chrome/browser/garbled_text_test_helper.cc View 1 chunk +59 lines, -0 lines 0 comments Download
A chrome/browser/garbled_text_url_tracker.h View 1 chunk +58 lines, -0 lines 0 comments Download
A chrome/browser/garbled_text_url_tracker.cc View 1 chunk +40 lines, -0 lines 0 comments Download
A chrome/browser/garbled_text_url_tracker_unittest.cc View 1 2 3 1 chunk +106 lines, -0 lines 0 comments Download
M chrome/browser/infobars/infobar_delegate.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/infobars/infobar_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_io_data.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_dependency_manager.cc View 1 2 3 4 5 6 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.h View 4 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 4 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 3 chunks +8 lines, -0 lines 0 comments Download
A chrome/browser/renderer_host/dummy_resource_dispatcher_host_delegate.h View 1 2 3 1 chunk +88 lines, -0 lines 0 comments Download
A chrome/browser/renderer_host/dummy_resource_dispatcher_host_delegate.cc View 1 2 1 chunk +111 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/advanced_options.html View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_wrapper.h View 3 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_wrapper.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/advanced_options_handler.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options2/advanced_options_handler2.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 6 3 chunks +8 lines, -0 lines 0 comments Download
M chrome/common/pref_names.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/render_messages.h View 1 2 3 4 5 6 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_render_view_observer.h View 1 2 3 4 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_render_view_observer.cc View 1 2 3 4 5 4 chunks +29 lines, -0 lines 0 comments Download
A chrome/test/data/garbled_text/foo.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/common/resource_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/resource_loader_bridge.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/glue/resource_loader_bridge.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/glue/weburlloader_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698