Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issue 9234068: Revert 119200 - Revert 119198 - First pass at implementing the MessageLoop interface. This includes… (Closed)

Created:
8 years, 11 months ago by brettw
Modified:
8 years, 11 months ago
Reviewers:
brettw, Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 119200 - Revert 119198 - First pass at implementing the MessageLoop interface. This includes a simple example and a helper class. The current example just asserts due to thread checks we have in there now, but this should provide a good starting point. BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/9097006 TBR=brettw@chromium.org Review URL: https://chromiumcodereview.appspot.com/9290040 TBR=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119268

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, --3 lines) Patch
M ppapi/ppapi_proxy.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/ppapi_shared.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/ppapi_sources.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/proxy/interface_list.cc View 3 chunks +4 lines, -0 lines 0 comments Download
A + ppapi/proxy/ppb_message_loop_proxy.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/proxy/ppb_message_loop_proxy.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M ppapi/shared_impl/resource.h View 1 chunk +1 line, -0 lines 0 comments Download
A + ppapi/thunk/ppb_message_loop_api.h View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
8 years, 11 months ago (2012-01-26 19:28:36 UTC) #1
Nico
8 years, 11 months ago (2012-01-27 04:26:36 UTC) #2
This is still adding static initializers. Why the reland?

Powered by Google App Engine
This is Rietveld 408576698