media/audio/linux/alsa_output.cc - Issue 9234066: Detect errors in audio output and report them upstream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/linux/alsa_output.cc

Issue 9234066: Detect errors in audio output and report them upstream. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/audio/linux/alsa_output.cc

diff --git a/media/audio/linux/alsa_output.cc b/media/audio/linux/alsa_output.cc

index b3f931d7ae7d2480815e5695dbfeda9149ee7612..535d1cbfae8e6423575e1f7f45d5beeb702853b3 100644

--- a/media/audio/linux/alsa_output.cc

+++ b/media/audio/linux/alsa_output.cc

@@ -268,6 +268,7 @@ bool AlsaPcmOutputStream::Open() {

// Finish initializing the stream if the device was opened successfully.

if (playback_handle_ == NULL) {

stop_stream_ = true;

+ return false;

} else {

bytes_per_output_frame_ = should_downmix_ ? 2 * bytes_per_sample_ :

bytes_per_frame_;