Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: client/mac/handler/breakpad_nlist_64.cc

Issue 9234054: Fix several clang warnings in breakpad. (Closed) Base URL: http://google-breakpad.googlecode.com/svn/trunk/src/
Patch Set: . Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | client/mac/sender/uploader.mm » ('j') | common/mac/MachIPC.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/mac/handler/breakpad_nlist_64.cc
===================================================================
--- client/mac/handler/breakpad_nlist_64.cc (revision 902)
+++ client/mac/handler/breakpad_nlist_64.cc (working copy)
@@ -190,9 +190,9 @@
struct exec buf;
if (read(fd, (char *)&buf, sizeof(buf)) != sizeof(buf) ||
(N_BADMAG(buf) && *((uint32_t *)&buf) != magic &&
- NXSwapBigLongToHost(*((long *)&buf)) != FAT_MAGIC) &&
- /* The following is the big-endian ppc64 check */
- (*((uint32_t*)&buf)) != FAT_MAGIC) {
+ NXSwapBigLongToHost(*((long *)&buf)) != FAT_MAGIC &&
+ /* The following is the big-endian ppc64 check */
+ (*((uint32_t*)&buf)) != FAT_MAGIC)) {
return -1;
}
« no previous file with comments | « no previous file | client/mac/sender/uploader.mm » ('j') | common/mac/MachIPC.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698