Issue 9234053: Revert 119171 - Maybe introduced a static initializer - or may be 119173

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9234053: Revert 119171 - Maybe introduced a static initializer - or may be 119173 (Closed)

Created:
8 years, 11 months ago by Ryan Sleevi

Modified:
8 years, 11 months ago

Reviewers:
ghc

CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 119171 - Maybe introduced a static initializer - or may be 119173 - replace custom <iq>-stanza protocol with push notifications (using PushNotifications* classes) in CacheInvalidationPacketHandler, and update unit test accordingly - extend notifier::Notification and PushNotificationsSendUpdateTask to allow specification of recipients (and recipient-specific data) Review URL: http://codereview.chromium.org/9190029 TBR=ghc@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119175

Patch Set 1 #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+247 lines, -165 lines)			Patch
M	chrome/browser/sync/notifier/cache_invalidation_packet_handler.h	View	5 chunks	+9 lines, -21 lines	0 comments	Download
M	chrome/browser/sync/notifier/cache_invalidation_packet_handler.cc	View	6 chunks	+227 lines, -60 lines	0 comments	Download
MM	chrome/browser/sync/notifier/cache_invalidation_packet_handler_unittest.cc	View	4 chunks	+5 lines, -15 lines	0 comments	Download
M	chrome/browser/sync/notifier/chrome_system_resources.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
MM	jingle/notifier/base/fake_base_task.cc	View	2 chunks	+3 lines, -27 lines	0 comments	Download
M	jingle/notifier/listener/notification_defines.h	View	2 chunks	+1 line, -16 lines	0 comments	Download
M	jingle/notifier/listener/notification_defines.cc	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	jingle/notifier/listener/push_notifications_send_update_task.cc	View	3 chunks	+1 line, -21 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages