native_client_sdk/src/examples/dlopen/eightball.cc - Issue 9234043: Support GLBIC example.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: native_client_sdk/src/examples/dlopen/eightball.cc

Issue 9234043: Support GLBIC example. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: re-enable the full build Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 #include <stdlib.h>
	Brad Chen 2012/01/28 01:00:52 Copyright headers on all source files. Copyright headers on all source files.
	2 #include <stdio.h>

	3

	4 extern "C"

	5 {

	6 __attribute__((visibility("default")))const char *Magic8Ball() {
	Brad Chen 2012/01/28 01:00:52 If you need to keep the __attribute__ stuff, maybe If you need to keep the __attribute__ stuff, maybe you can put the "const char ..." on a newline so people can more easily parse the GNU extensions vs. the standard C. noelallen1 2012/01/31 21:03:21 Done. Show quoted text On 2012/01/28 01:00:52, Brad Chen wrote: > If you need to keep the __attribute__ stuff, maybe you can put the "const char > ..." on a newline so people can more easily parse the GNU extensions vs. the > standard C. Done.
	7 const int NSIDES = 8;

	8 const char* answer[] = {

	9 "YES",

	10 "NO",

	11 "MAYBE",

	12 "MAYBE NOT",

	13 "DEFINITELY",

	14 "ASK ME TOMORROW",

	15 "PARTLY CLOUDY",

	16 "42",

	17 };

	18

	19 return answer[rand() % NSIDES];

	20 }

	21 }
	Brad Chen 2012/01/28 01:00:52 Not worth using the {} for extern "C" if there is Not worth using the {} for extern "C" if there is only one declaration. noelallen1 2012/01/31 21:03:21 Done. Show quoted text On 2012/01/28 01:00:52, Brad Chen wrote: > Not worth using the {} for extern "C" if there is only one declaration. Done.
	22

OLD	NEW