Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 9233046: Bug fixes for basic playback test. (Closed)

Created:
8 years, 10 months ago by DaleCurtis
Modified:
8 years, 10 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, John Grabowski, Nirnimesh, acolwell+watch_chromium.org, annacc+watch_chromium.org, dennis_jeffrey, anantha, dyu1, vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org, shadi
Visibility:
Public.

Description

Bug fixes for basic playback test. Does the following: - Removes race between autoplay and explicit .play(). - Removes race between seeked and .play(). - Adds logging for several other failure type events. - Moves the events.join() code into Python so better errors can be reported. - Instead of opening a new tab for each video in the matrix, reuses the same tab for each playback. Ensures abort and emptied events fire on src switch. Reusing the same tab was necessary to prevent the video from hanging on the Linux bot, as a nice bonus it shaves seconds off the runtime. BUG=111603 TEST=Ran on Linux bot.

Patch Set 1 #

Patch Set 2 : Semicolon. #

Total comments: 8

Patch Set 3 : Code review fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -26 lines) Patch
M chrome/test/data/media/html/media_basic_playback.html View 1 2 2 chunks +20 lines, -13 lines 0 comments Download
M chrome/test/functional/media/media_basic_playback.py View 1 2 1 chunk +32 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
DaleCurtis
8 years, 10 months ago (2012-01-31 00:59:18 UTC) #1
Ami GONE FROM CHROMIUM
lgtm https://chromiumcodereview.appspot.com/9233046/diff/3001/chrome/test/data/media/html/media_basic_playback.html File chrome/test/data/media/html/media_basic_playback.html (right): https://chromiumcodereview.appspot.com/9233046/diff/3001/chrome/test/data/media/html/media_basic_playback.html#newcode17 chrome/test/data/media/html/media_basic_playback.html:17: var events = []; Init unnecessary since startTest() ...
8 years, 10 months ago (2012-01-31 20:26:16 UTC) #2
DaleCurtis
8 years, 10 months ago (2012-01-31 22:31:54 UTC) #3
https://chromiumcodereview.appspot.com/9233046/diff/3001/chrome/test/data/med...
File chrome/test/data/media/html/media_basic_playback.html (right):

https://chromiumcodereview.appspot.com/9233046/diff/3001/chrome/test/data/med...
chrome/test/data/media/html/media_basic_playback.html:17: var events = [];
On 2012/01/31 20:26:16, Ami Fischman wrote:
> Init unnecessary since startTest() does it anyway.

Done.

https://chromiumcodereview.appspot.com/9233046/diff/3001/chrome/test/data/med...
chrome/test/data/media/html/media_basic_playback.html:19: // List of events to
log.
On 2012/01/31 20:26:16, Ami Fischman wrote:
> I worry this will be flaky b/c it's overly specific; if the timing of the impl
> changes, you may get a stalled event, or not, and there's no reason for the
test
> to assert on it.
> I think you want this to get better diags for failures.
> Maybe the right thing to do is to have a logEventsForDiagnostics and
> logEventsForCorrectness with two different sets of events.

Discussed offline. Events in this list are those which are expected plus those
which are unexpected and will have a negative impact on playback.

https://chromiumcodereview.appspot.com/9233046/diff/3001/chrome/test/data/med...
chrome/test/data/media/html/media_basic_playback.html:21: 'abort', 'emptied',
'error', 'playing', 'stalled', 'suspend',
On 2012/01/31 20:26:16, Ami Fischman wrote:
> 2-space indent

Done.

https://chromiumcodereview.appspot.com/9233046/diff/3001/chrome/test/function...
File chrome/test/functional/media/media_basic_playback.py (right):

https://chromiumcodereview.appspot.com/9233046/diff/3001/chrome/test/function...
chrome/test/functional/media/media_basic_playback.py:28: # Correct events for
the first iteration and every iteration thereafter.
On 2012/01/31 20:26:16, Ami Fischman wrote:
> s/correct/expected/ here and below.

Done.

Powered by Google App Engine
This is Rietveld 408576698