Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Unified Diff: client/dom/templates/dom/frog/frog_dom.darttemplate

Issue 9233028: Frog dart:dom using interfaces and native implementation classes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/dom/src/frog_FactoryProviders.dart ('k') | frog/gen.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/dom/templates/dom/frog/frog_dom.darttemplate
diff --git a/client/dom/templates/dom/frog/frog_dom.darttemplate b/client/dom/templates/dom/frog/frog_dom.darttemplate
index fb6c061c351e2daaf63a2bd8d496100fd4599a11..6a890559fa63ff99b9dcfb4e4961d104738b688a 100644
--- a/client/dom/templates/dom/frog/frog_dom.darttemplate
+++ b/client/dom/templates/dom/frog/frog_dom.darttemplate
@@ -15,14 +15,13 @@ $!GENERATED_DART_FILES
#source('src/RequestAnimationFrameCallback.dart');
#source('src/TimeoutHandler.dart');
#source('src/_Collections.dart');
-// #source('src/_FactoryProviders.dart');
+#source('src/frog_FactoryProviders.dart');
#source('src/_ListIterators.dart');
#source('src/_Lists.dart');
-// TODO(jmesserly): 'native' here is aWork-around for Frog bug. Frog needs to
-// be smarter about inheriting from a hidden native type (in this case
-// DOMWindow)
-class Window extends DOMWindow native "*Window" {}
+// TODO(sra): What 'window' do we get in a worker? Perhaps this
+// should return the interface type.
DOMWindow get window() native "return window;";
+
// TODO(vsm): Revert to Dart method when 508 is fixed.
HTMLDocument get document() native "return window.document;";
« no previous file with comments | « client/dom/src/frog_FactoryProviders.dart ('k') | frog/gen.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698