tools/testing/run_selenium.py - Issue 9233015: Make test.dart run web tests on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/run_selenium.py

Issue 9233015: Make test.dart run web tests on Windows. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: '' Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/testing/run_selenium.py

===================================================================

--- tools/testing/run_selenium.py (revision 3477)

+++ tools/testing/run_selenium.py (working copy)

@@ -49,6 +49,8 @@

lambda driver : ('PASS' in driver.page_source) or

('FAIL' in driver.page_source))

source = browser.page_source

+ except selenium.common.exceptions.TimeoutException:

+ source = 'FAIL'

Bill Hesse 2012/01/22 20:52:02 Can this be 'FAIL (timeout)', or does it need to b

Emily Fortuna 2012/01/23 18:27:41 Fixed! On 2012/01/22 20:52:02, Bill Hesse wrote:

finally:

# A timeout exception is thrown if nothing happens within the time limit.

if browser != 'chrome':