Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 9233015: Make test.dart run web tests on Windows. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/test_runner.dart
===================================================================
--- tools/testing/dart/test_runner.dart (revision 3477)
+++ tools/testing/dart/test_runner.dart (working copy)
@@ -243,6 +243,11 @@
void runCommand(String executable,
List<String> arguments,
void exitHandler(int exitCode)) {
+ if (new Platform().operatingSystem() == 'windows') {
+ // Windows can't handle the first command if it is a .bat file or the like
+ // with the slashes going the other direction.
+ executable = executable.replaceAll('/', '\\');
Bill Hesse 2012/01/22 20:52:02 Should we file a bug, and make the Platform class
Emily Fortuna 2012/01/23 18:27:41 We could... Currently this seems to be the default
+ }
process = new Process.start(executable, arguments);
process.exitHandler = exitHandler;
startTime = new Date.now();

Powered by Google App Engine
This is Rietveld 408576698