Make test.dart run web tests on Windows.

tools/testing/dart/test_suite.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library("test_suite");
 
 #import("status_file_parser.dart");
 #import("test_runner.dart");
 #import("multitest.dart");
 
@@ skipping 391 matching lines @@
             domLibraryImport,
             '$dartDir/tests/isolate/src/TestFramework.dart',
             dartLibraryFilename));
         dartWrapper.closeSync();
       } else {
         dartWrapperFilename = testPath;
         // TODO(whesse): Once test.py is retired, adjust the relative path in
         // the client/samples/dartcombat test to its css file, remove the
         // "../../" from this path, and move this out of the isWebTest guard.
         // Also remove getHtmlName, and just use test.html.
-        htmlPath = '${tempDir.path}/../../${getHtmlName(filename)}';
+        // TODO(efortuna): this shortening of htmlFilename is a band-aid until 
+        // the above gets fixed. Windows cannot have paths that are longer than
+        // 260 characters, and without this hack, we were running past the
+        // limit.

[Bill Hesse, 2012/01/22 20:52:02]

Let's file a bug - this needs to get fixed.

[Emily Fortuna, 2012/01/23 18:27:41]

File a bug on Microsoft? This is a Windows API issue/decision. See "Maximum Path
Length Limitation" here: http://msdn.microsoft.com/en-us/library/aa365247.aspx 

On 2012/01/22 20:52:02, Bill Hesse wrote:

[Emily Fortuna, 2012/01/23 19:18:49]

Talked to Siggi about this. Once you fix your above TODO (just use test.hml
instead of getHtmlName) this problem should go away.

On 2012/01/23 18:27:41, Emily Fortuna wrote:

+        String htmlFilename = getHtmlName(filename);
+        htmlFilename = htmlFilename.substring(htmlFilename.length~/2);

[Siggi Cherem (dart-lang), 2012/01/23 00:29:02]

could we do this selectively (only when we are close to the limit?)

+        htmlPath = '${tempDir.path}/../../$htmlFilename';
       }
       final String scriptPath = (component == 'dartium') ?
           dartWrapperFilename : compiledDartWrapperFilename;
       // Create the HTML file for the test.
       RandomAccessFile htmlTest = new File(htmlPath).openSync(FileMode.WRITE);
       htmlTest.writeStringSync(GetHtmlContents(
           filename,
           '$dartDir/client/testing/unittest/test_controller.js',
           scriptType,
           scriptPath));
@@ skipping 10 matching lines @@
           compilerArgs.addAll(vmOptions);
           compilerArgs.add('--ignore-unrecognized-flags');
           compilerArgs.add('--out');
           compilerArgs.add(compiledDartWrapperFilename);
           compilerArgs.add(dartWrapperFilename);
           // TODO(whesse): Add --fatal-type-errors if needed.
           break;
         case 'frogium':
         case 'webdriver':
           String libdir = configuration['froglib'];
-          if (libdir == '') {
+          if (libdir == '' && ! compilerExecutable.endsWith('frogsh')) {

[Siggi Cherem (dart-lang), 2012/01/23 00:29:02]

remove space after !

[Emily Fortuna, 2012/01/23 18:27:41]

Done.

             libdir = '$dartDir/frog/lib';
           }
-          compilerArgs.addAll(['--libdir=$libdir',
-                               '--compile-only',
+          if (!compilerExecutable.endsWith('frogsh')) {

[Siggi Cherem (dart-lang), 2012/01/23 00:29:02]

I thought there was going to be a different libdir for frogsh (instead of
nothing)

+            compilerArgs.add('--libdir=$libdir');
+          }
+          compilerArgs.addAll(['--compile-only',
                                '--out=$compiledDartWrapperFilename']);
           compilerArgs.addAll(vmOptions);
           compilerArgs.add(dartWrapperFilename);
           break;
         case 'dartium':
           // No compilation phase.
           compilerExecutable = null;
           compilerArgs = null;
           break;
         default:
           Expect.fail('unimplemented component $component');
       }
 
       String executable = getFilename(dumpRenderTreeFilename);
       List<String> args;
       if (component == 'webdriver') {
-        // TODO(efortuna): These paths are not OS independent! 
         executable = '$dartDir/tools/testing/run_selenium.py';
-        args = ['--out', htmlPath, '--browser', configuration['browser']];
+        if (new Platform().operatingSystem() == 'windows') {
+          // For Windows, the first command, must have the Windows 
+          // slash direction.
+          executable = executable.replaceAll('/', '\\');

[Bill Hesse, 2012/01/22 20:52:02]

TODO, with bug number.

[Emily Fortuna, 2012/01/23 18:27:41]

Done.

+        }
+        args = ['--out=$htmlPath', '--browser=${configuration["browser"]}'];
       } else {
         args = ['--no-timeout'];
         if (component == 'dartium') {
           var dartFlags = ['--ignore-unrecognized-flags'];
           if (configuration["checked"]) {
             dartFlags.add('--enable_asserts');
             dartFlags.add("--enable_type_checks");
           }
           dartFlags.addAll(vmOptions);
           args.add('--dart-flags=${Strings.join(dartFlags, " ")}');
@@ skipping 423 matching lines @@
           return 'frog/bin/frog$postfix';
       case 'frogsh':
         return 'frog/bin/frogsh$postfix';
       default:
         throw "Unknown executable for: ${configuration['component']}";
     }
   }
 
   static String compilerName(Map configuration) {
     String postfix =
-        (new Platform().operatingSystem() == 'windows') ? '.exe' : '';
+        ((new Platform().operatingSystem() == 'windows') && 
+        (configuration['component'] != 'frogium' &&
+        configuration['component'] != 'webdriver')) ? '.exe' : '';
     switch (configuration['component']) {
       case 'chromium':
       case 'dartc':
         return 'compiler/bin/dartc$postfix';
       case 'frogium':
       case 'webdriver':
         return 'frog/bin/frogsh$postfix';

[Bill Hesse, 2012/01/22 20:52:02]

Can't you just remove $postfix from this line here?

[Siggi Cherem (dart-lang), 2012/01/23 00:29:02]

Also: if there is a postfix, it should be .bat in this case.

[Emily Fortuna, 2012/01/23 18:27:41]

@Siggi: For windows you can call the .bat file without the .bat extension.
@Bill: Touché. Done.

On 2012/01/23 00:29:02, sigmund wrote:

       default:
         throw "Unknown compiler for: ${configuration['component']}";
     }
   }
 
   static String dartShellFileName(Map configuration) {
     var name = '${buildDir(configuration)}/${executableName(configuration)}';
     if (!(new File(name)).existsSync()) {
       throw "Executable '$name' does not exist";
     }
@@ skipping 108 matching lines @@
  * $noCrash tests are expected to be flaky but not crash
  * $pass tests are expected to pass
  * $failOk tests are expected to fail that we won't fix
  * $fail tests are expected to fail that we should fix
  * $crash tests are expected to crash that we should fix
  * $timeout tests are allowed to timeout
 """;
     print(report);
    }
 }