Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 9233008: Flag auto-enrollment register requests. (Closed)

Created:
8 years, 11 months ago by Joao da Silva
Modified:
8 years, 11 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, tslo_google.com, binzhao
Visibility:
Public.

Description

Flag auto-enrollment register requests. BUG=chromium-os:23063 TEST=DeviceTokenFetcherTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118647

Patch Set 1 #

Patch Set 2 : Rebased, update copyright year #

Total comments: 2

Patch Set 3 : Renamed is_auto_enrollment to known_machine_id #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -5 lines) Patch
M chrome/browser/chromeos/login/enrollment/enterprise_enrollment_screen.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/browser_policy_connector.h View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/policy/browser_policy_connector.cc View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/policy/cloud_policy_data_store.h View 1 2 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/policy/cloud_policy_data_store.cc View 1 2 3 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/policy/device_token_fetcher.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/policy/device_token_fetcher_unittest.cc View 1 2 2 chunks +35 lines, -0 lines 0 comments Download
M chrome/browser/policy/proto/device_management_backend.proto View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Joao da Silva
Here's a smaller one :-)
8 years, 11 months ago (2012-01-20 12:51:59 UTC) #1
Mattias Nissler (ping if slow)
LGTM, but I'd rather s/is_auto_enrollment/known_machine_id/ in the entire patch for consistency. https://chromiumcodereview.appspot.com/9233008/diff/2001/chrome/browser/policy/device_token_fetcher.cc File chrome/browser/policy/device_token_fetcher.cc (right): ...
8 years, 11 months ago (2012-01-20 12:57:11 UTC) #2
Joao da Silva
http://codereview.chromium.org/9233008/diff/2001/chrome/browser/policy/device_token_fetcher.cc File chrome/browser/policy/device_token_fetcher.cc (right): http://codereview.chromium.org/9233008/diff/2001/chrome/browser/policy/device_token_fetcher.cc#newcode120 chrome/browser/policy/device_token_fetcher.cc:120: request->set_known_machine_id(true); On 2012/01/20 12:57:11, Mattias Nissler wrote: > Maybe ...
8 years, 11 months ago (2012-01-20 14:42:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/9233008/10
8 years, 11 months ago (2012-01-20 14:42:42 UTC) #4
commit-bot: I haz the power
Try job failure for 9233008-10 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 11 months ago (2012-01-20 16:21:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/9233008/10
8 years, 11 months ago (2012-01-20 16:42:26 UTC) #6
commit-bot: I haz the power
Try job failure for 9233008-10 (retry) on mac_rel for step "update". It's a second try, ...
8 years, 11 months ago (2012-01-20 18:04:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/9233008/8001
8 years, 11 months ago (2012-01-22 11:49:26 UTC) #8
Joao da Silva
@tslo, @binzhao: FYI
8 years, 11 months ago (2012-01-22 12:32:15 UTC) #9
commit-bot: I haz the power
8 years, 11 months ago (2012-01-22 14:38:40 UTC) #10
Try job failure for 9233008-8001 (retry) on win_rel for step "base_unittests".
It's a second try, previously, steps "base_unittests, browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698