Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: src/ic.cc

Issue 9233006: Removed IsPropertyOrTransition method. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen.cc ('k') | src/property.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1188 matching lines...) Expand 10 before | Expand all | Expand 10 after
1199 } else if (state == MONOMORPHIC) { 1199 } else if (state == MONOMORPHIC) {
1200 set_target(*megamorphic_stub()); 1200 set_target(*megamorphic_stub());
1201 } 1201 }
1202 1202
1203 TRACE_IC("KeyedLoadIC", name, state, target()); 1203 TRACE_IC("KeyedLoadIC", name, state, target());
1204 } 1204 }
1205 1205
1206 1206
1207 static bool StoreICableLookup(LookupResult* lookup) { 1207 static bool StoreICableLookup(LookupResult* lookup) {
1208 // Bail out if we didn't find a result. 1208 // Bail out if we didn't find a result.
1209 if (!lookup->IsPropertyOrTransition() || !lookup->IsCacheable()) return false; 1209 if (!lookup->IsFound() || lookup->type() == NULL_DESCRIPTOR) return false;
1210 1210
1211 // If the property is read-only, we leave the IC in its current 1211 // Bail out if inline caching is not allowed.
1212 // state. 1212 if (!lookup->IsCacheable()) return false;
1213
1214 // If the property is read-only, we leave the IC in its current state.
1213 if (lookup->IsReadOnly()) return false; 1215 if (lookup->IsReadOnly()) return false;
1214 1216
1215 return true; 1217 return true;
1216 } 1218 }
1217 1219
1218 1220
1219 static bool LookupForWrite(Handle<JSObject> receiver, 1221 static bool LookupForWrite(Handle<JSObject> receiver,
1220 Handle<String> name, 1222 Handle<String> name,
1221 LookupResult* lookup) { 1223 LookupResult* lookup) {
1222 receiver->LocalLookup(*name, lookup); 1224 receiver->LocalLookup(*name, lookup);
(...skipping 1202 matching lines...) Expand 10 before | Expand all | Expand 10 after
2425 #undef ADDR 2427 #undef ADDR
2426 }; 2428 };
2427 2429
2428 2430
2429 Address IC::AddressFromUtilityId(IC::UtilityId id) { 2431 Address IC::AddressFromUtilityId(IC::UtilityId id) {
2430 return IC_utilities[id]; 2432 return IC_utilities[id];
2431 } 2433 }
2432 2434
2433 2435
2434 } } // namespace v8::internal 2436 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/hydrogen.cc ('k') | src/property.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698