Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 9233005: Split side-effect flags from flags in Hydrogen instructions. (Closed)

Created:
8 years, 11 months ago by danno
Modified:
8 years, 11 months ago
Reviewers:
Sven Panne
CC:
v8-dev, Kevin Millikin (Chromium)
Visibility:
Public.

Description

Split GVN flags from flags in Hydrogen instructions. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=10460

Patch Set 1 #

Patch Set 2 : Fix bug #

Patch Set 3 : Tweaks #

Patch Set 4 : Kevin's feedback #

Patch Set 5 : Fix whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -107 lines) Patch
M src/hydrogen.h View 1 2 3 4 3 chunks +5 lines, -4 lines 0 comments Download
M src/hydrogen.cc View 1 2 3 4 13 chunks +40 lines, -36 lines 0 comments Download
M src/hydrogen-instructions.h View 1 2 3 4 30 chunks +84 lines, -55 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 2 3 3 chunks +11 lines, -11 lines 0 comments Download
M src/utils.h View 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
danno
PTAL
8 years, 11 months ago (2012-01-20 13:47:33 UTC) #1
Sven Panne
8 years, 11 months ago (2012-01-20 13:58:52 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698