Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 9233002: Fix solaris build (VirtualMemory). (Closed)

Created:
7 years, 10 months ago by Yang
Modified:
7 years, 10 months ago
Reviewers:
noordhuis
CC:
v8-dev
Visibility:
Public.

Description

Fix solaris build (VirtualMemory). BUG=v8:1761 TEST= Committed: https://code.google.com/p/v8/source/detail?r=10463

Patch Set 1 #

Patch Set 2 : Fix libraries in gyp. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -15 lines) Patch
M src/platform-solaris.cc View 2 chunks +99 lines, -15 lines 0 comments Download
M tools/gyp/v8.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Yang
This is based on your patch, with slight changes. Please confirm that this indeed works ...
7 years, 10 months ago (2012-01-20 08:30:21 UTC) #1
noordhuis
7 years, 10 months ago (2012-01-20 13:19:02 UTC) #2
On 2012/01/20 08:30:21, Yang wrote:
> This is based on your patch, with slight changes. Please confirm that this
> indeed works on Solaris.

Confirmed. Applies cleanly, works as intended.

Powered by Google App Engine
This is Rietveld 408576698