Issue 9233002: Fix solaris build (VirtualMemory).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9233002: Fix solaris build (VirtualMemory). (Closed)

Created:
8 years, 11 months ago by Yang

Modified:
8 years, 11 months ago

Reviewers:
noordhuis

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix solaris build (VirtualMemory). BUG=v8:1761 TEST= Committed: https://code.google.com/p/v8/source/detail?r=10463

Patch Set 1 #

Patch Set 2 : Fix libraries in gyp. #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+103 lines, -15 lines)			Patch
	M	src/platform-solaris.cc	View		2 chunks	+99 lines, -15 lines	0 comments	Download
	M	tools/gyp/v8.gyp	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yang

This is based on your patch, with slight changes. Please confirm that this indeed works ...

8 years, 11 months ago (2012-01-20 08:30:21 UTC) #1

noordhuis

8 years, 11 months ago (2012-01-20 13:19:02 UTC) #2

On 2012/01/20 08:30:21, Yang wrote:
> This is based on your patch, with slight changes. Please confirm that this
> indeed works on Solaris.

Confirmed. Applies cleanly, works as intended.

Expand Messages | Collapse Messages