Upload UMA data using protocol buffers.

chrome/browser/chrome_browser_main.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_browser_main.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 1036 matching lines @@
     // on recording, but not reporting, otherwise tests fail.
     metrics->StartRecordingOnly();
     return;
   }
 
   if (IsMetricsReportingEnabled())
     metrics->Start();
 }
 
 bool ChromeBrowserMainParts::IsMetricsReportingEnabled() {
+  return true;

[Ilya Sherman, 2012/02/17 06:07:44]

TODO(isherman): This is handy for testing for now... should definitely be
removed prior to committing.

[jar (doing other things), 2012/02/23 01:59:18]

I had proposed putting in this exact code in a:
#if !defined(NDEBUG)

This would facilitate testing and developing... and allow us to drop in
interesting DCHECKs to prevent regressions.

WDYT?


On 2012/02/17 06:07:44, Ilya Sherman wrote:

[Ilya Sherman, 2012/02/24 02:10:06]

Sounds fine to me, but probably best to do in a separate CL.  I think MAD is
planning to make this change sometime this week, when he gets around to it...

[jar (doing other things), 2012/02/27 20:35:34]

Since it would be a bad thing to check this in by accident, I'd suggest that you
at least (tentatively) enclose it in an if !defined(NDEBUG).  If you checked it
in by accident, it would be no big deal that way.

I think it makes it much easier to test this way (as you noted).


On 2012/02/24 02:10:06, Ilya Sherman wrote:

[Ilya Sherman, 2012/02/28 00:23:10]

D'oh.  Re-removed from this CL, and added the "#if !defined(NDEBUG)" wrapper to
my local diff file that I patch in for testing.

   // If the user permits metrics reporting with the checkbox in the
   // prefs, we turn on recording.  We disable metrics completely for
   // non-official builds.
   bool enabled = false;
 #if defined(GOOGLE_CHROME_BUILD)
 #if defined(OS_CHROMEOS)
   chromeos::CrosSettings::Get()->GetBoolean(chromeos::kStatsReportingPref,
                                             &enabled);
 #else
   enabled = local_state_->GetBoolean(prefs::kMetricsReportingEnabled);
@@ skipping 891 matching lines @@
     if (base::win::GetVersion() <= base::win::VERSION_XP)
       uma_name += "_XP";
 
     uma_name += "_PreRead_";
     uma_name += pre_read_percentage;
     AddPreReadHistogramTime(uma_name.c_str(), time);
   }
 #endif
 #endif
 }