Issue 9232070: Add UMA protocol buffers to Chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9232070: Add UMA protocol buffers to Chrome. (Closed)

Created:
8 years, 11 months ago by Ilya Sherman

Modified:
8 years, 10 months ago

Reviewers:
ian fette, jar (doing other things)

CC:
chromium-reviews, Aaron Boodman, MAD, Ilya Sherman, jar (doing other things), mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Add UMA protocol buffers to Chrome. BUG=109817 TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119780

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+463 lines, -0 lines)			Patch
M	chrome/chrome_common.gypi	View	2 chunks	+18 lines, -0 lines	0 comments	Download
A	chrome/common/metrics/proto/chrome_user_metrics_extension.proto	View	1 chunk	+43 lines, -0 lines	0 comments	Download
A	chrome/common/metrics/proto/histogram_event.proto	View	1 chunk	+46 lines, -0 lines	0 comments	Download
A	chrome/common/metrics/proto/omnibox_event.proto	View	1 chunk	+106 lines, -0 lines	0 comments	Download
A	chrome/common/metrics/proto/system_profile.proto	View	1 chunk	+229 lines, -0 lines	0 comments	Download
A	chrome/common/metrics/proto/user_action_event.proto	View	1 chunk	+21 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Ilya Sherman

These are the protobufs in cl/26086771, with a few comments redacted to avoid leaking internal-only ...

8 years, 11 months ago (2012-01-28 08:04:45 UTC) #1

ian fette

lgtm On 2012/01/28 08:04:45, Ilya Sherman wrote: > These are the protobufs in cl/26086771, with ...

8 years, 10 months ago (2012-01-30 20:37:53 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/9232070/1

8 years, 10 months ago (2012-01-30 22:11:24 UTC) #3

Change committed as 119780