Added `gclient hookinfo`. This will be used to convert hooks into

gclient.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Meta checkout manager supporting both Subversion and GIT.
 
 Files
   .gclient      : Current client configuration, written by 'config' command.
                   Format is a Python script defining 'solutions', a list whose
@@ skipping 567 matching lines @@
       for s in self.dependencies:
         work_queue.enqueue(s)
 
   @gclient_utils.lockedmethod
   def _run_is_done(self, file_list, parsed_url):
     # Both these are kept for hooks that are run as a separate tree traversal.
     self._file_list = file_list
     self._parsed_url = parsed_url
     self._processed = True
 
-  def RunHooksRecursively(self, options):
+  def RunHooksRecursively(self, options, action=None):
     """Evaluates all hooks, running actions as needed. run()

[M-A Ruel, 2012/01/30 19:23:07]

... running |action| for each hook. or something like that.

[szager, 2012/01/31 00:22:20]

Done.

     must have been called before to load the DEPS."""
     assert self.hooks_ran == False
+    if not action:

[M-A Ruel, 2012/01/30 19:23:07]

action = action or self._RunHookAction

[szager, 2012/01/31 00:22:20]

Done.

+      action = self._RunHookAction
     if not self.should_process or not self.recursion_limit:
       # Don't run the hook when it is above recursion_limit.
       return
     # If "--force" was specified, run all hooks regardless of what files have
     # changed.
     if self.deps_hooks:
       # TODO(maruel): If the user is using git or git-svn, then we don't know
       # what files have changed so we always run all hooks. It'd be nice to fix
       # that.
       if (options.force or
           isinstance(self.parsed_url, self.FileImpl) or
           gclient_scm.GetScmName(self.parsed_url) in ('git', None) or
           os.path.isdir(os.path.join(self.root.root_dir, self.name, '.git'))):
         for hook_dict in self.deps_hooks:
-          self._RunHookAction(hook_dict, [])
+          action(hook_dict, [])
       else:
         # Run hooks on the basis of whether the files from the gclient operation
         # match each hook's pattern.
         for hook_dict in self.deps_hooks:
           pattern = re.compile(hook_dict['pattern'])
           matching_file_list = [
               f for f in self.file_list_and_children if pattern.search(f)
           ]
           if matching_file_list:
-            self._RunHookAction(hook_dict, matching_file_list)
+            action(hook_dict, matching_file_list)
     for s in self.dependencies:
-      s.RunHooksRecursively(options)
+      s.RunHooksRecursively(options, action=action)

[M-A Ruel, 2012/01/30 19:23:07]

My idea was to still call _RunHookAtion but add an argument to it. The new code
duplicate some logic. :/

What about refactoring it:
1. Rename RunHooksRecursively() to GetHooksToRun() to grab all the hooks that
should be run.
2. Have the caller RunHooks() or HookINfo() to run/print the hooks as wanted.

I think it'd be saner to maintain. wdyt?

[szager, 2012/01/31 00:22:20]

OK.  Patch is now much bigger...

 
   def _RunHookAction(self, hook_dict, matching_file_list):
     """Runs the action from a single hook."""
     # A single DEPS file can specify multiple hooks so this function can be
     # called multiple times on a single Dependency.
     #assert self.hooks_ran == False
     self._hooks_ran = True
     logging.debug(hook_dict)
     logging.debug(matching_file_list)
     command = hook_dict['action'][:]
@@ skipping 444 matching lines @@
       for d in self.root.subtree(False):
         if self._options.actual:
           entries[d.name] = GetURLAndRev(d)
         else:
           entries[d.name] = d.parsed_url
       keys = sorted(entries.keys())
       for x in keys:
         print('%s: %s' % (x, entries[x]))
     logging.info(str(self))
 
+  def HookInfo(self):
+    work_queue = gclient_utils.ExecutionQueue(self._options.jobs, None)
+    for s in self.dependencies:
+      work_queue.enqueue(s)
+    work_queue.flush({}, None, [], options=self._options)
+    hooks = []
+    def _process_hook(hook_dict, matching_file_list):
+      command = hook_dict['action'][:]
+      if '$matching_files' in command:
+        splice_index = command.index('$matching_files')
+        command[splice_index:splice_index + 1] = matching_file_list
+      hooks.append(command)
+    self.RunHooksRecursively(self._options, action=_process_hook)
+    return hooks
+
   def ParseDepsFile(self):
     """No DEPS to parse for a .gclient file."""
     raise gclient_utils.Error('Internal error')
 
   @property
   def root_dir(self):
     """Root directory of gclient checkout."""
     return self._root_dir
 
   @property
@@ skipping 323 matching lines @@
                          'version of all repositories to reproduce the tree, '
                          'implies -a')
   (options, args) = parser.parse_args(args)
   client = GClient.LoadCurrentConfig(options)
   if not client:
     raise gclient_utils.Error('client not configured; see \'gclient config\'')
   client.PrintRevInfo()
   return 0
 
 
+def CMDhookinfo(parser, args):
+  """Output the hooks that would be run by `gclient runhooks`"""
+
+  (options, args) = parser.parse_args(args)
+  client = GClient.LoadCurrentConfig(options)
+  if not client:
+    raise gclient_utils.Error('client not configured; see \'gclient config\'')
+  print client.HookInfo()
+  return 0
+
+
 def Command(name):
   return getattr(sys.modules[__name__], 'CMD' + name, None)
 
 
 def CMDhelp(parser, args):
   """Prints list of commands or help for a specific command."""
   (_, args) = parser.parse_args(args)
   if len(args) == 1:
     return Main(args + ['--help'])
   parser.print_help()
@@ skipping 96 matching lines @@
   except (gclient_utils.Error, subprocess2.CalledProcessError), e:
     print >> sys.stderr, 'Error: %s' % str(e)
     return 1
 
 
 if '__main__' == __name__:
   fix_encoding.fix_encoding()
   sys.exit(Main(sys.argv[1:]))
 
 # vim: ts=2:sw=2:tw=80:et: